Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add openSSL_ROOT_DIR check on macos #2716

Merged
merged 1 commit into from
Jul 29, 2024
Merged

add openSSL_ROOT_DIR check on macos #2716

merged 1 commit into from
Jul 29, 2024

Conversation

lqxhub
Copy link
Contributor

@lqxhub lqxhub commented Jul 26, 2024

What problem does this PR solve?

Issue Number: #2714

Problem Summary:
On macos, originally it was mandatory to set OPENSSL_ROOT_DIR to /usr/local/opt-openssl, but now a judgment is added, only if OPENSSL_ROOT_DIR is not set. Is set to /usr/local/opt-openssl

What is changed and the side effects?

Changed:

Added a judgment to the cmake file

Side effects:

  • Performance effects(性能影响): NO

  • Breaking backward compatibility(向后兼容性): YES


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

Copy link
Contributor

@chenBright chenBright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wwbmmm wwbmmm merged commit fc56be6 into apache:master Jul 29, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants