Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support shutdown write and notify for success write #2547

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

chenBright
Copy link
Contributor

@chenBright chenBright commented Feb 25, 2024

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

  1. 支持半关闭:无需SetFailed,关闭写入端,但不影响读数据。
  2. 支持在数据写入socket写入成功后调用id_wait回调函数:对于一些请求和响应不是一一对应的场景,例如WebSocket、TCP Stream客户端、Streaming rpc等,只需要关注数据是否写入成功。数据写入socket写入成功后调用id_wait回调函数,可以统计成功率、耗时等。内置服务是否可以观测 streaming rpc #2545

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@chenBright chenBright force-pushed the shutdown_and_notify branch 8 times, most recently from 00ed97b to 4ed6ab5 Compare February 26, 2024 06:36
@chenBright
Copy link
Contributor Author

@wwbmmm 有空看看这个PR

@chenBright chenBright force-pushed the shutdown_and_notify branch from 4ed6ab5 to 8c2de29 Compare March 12, 2024 16:02
@chenBright chenBright added the enhancement improvements on existing features label Mar 13, 2024
@chenBright chenBright force-pushed the shutdown_and_notify branch from 8c2de29 to dea1ca8 Compare March 16, 2024 08:29
@chenBright chenBright force-pushed the shutdown_and_notify branch from dea1ca8 to f436e4d Compare March 16, 2024 08:51
src/brpc/socket.cpp Outdated Show resolved Hide resolved
src/brpc/socket.h Outdated Show resolved Hide resolved
@chenBright chenBright force-pushed the shutdown_and_notify branch from d3c96c6 to 53ffd41 Compare March 18, 2024 16:42
@wwbmmm
Copy link
Contributor

wwbmmm commented Mar 21, 2024

LGTM

@wwbmmm wwbmmm merged commit c666ea4 into apache:master Apr 8, 2024
20 checks passed
@chenBright chenBright deleted the shutdown_and_notify branch April 8, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants