-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support grpc health check #2493
support grpc health check #2493
Conversation
b9a8322
to
b5c97b2
Compare
HealthService好像已经支持了吧。 |
支持的grpc 官方定义的健康检查协议,response是这样的: |
请求对应的path是: /grpc.health.v1.Health/Check |
health_reporter满足不了grpc健康检查的要求吧,获取不了HealthCheckRequest和设置不了HealthCheckResponse。 |
grpc和http 都是写的 cntl->response_attachment(),理论上是可以定制的。 |
可以补充一下UT吗 |
好的,我补一下。 |
ed56726
to
ec082be
Compare
ec082be
to
de5ce5c
Compare
|
9c9d739
to
2dfd003
Compare
2dfd003
to
de5ce5c
Compare
LGTM |
1 similar comment
LGTM |
* support grpc health check protocol * add grpc health check ut --------- Co-authored-by: jiangyuting <jiangyutingwangyi@163.com>
What problem does this PR solve?
支持grpc的健康检查协议
Issue Number:
Problem Summary:
What is changed and the side effects?
Changed:
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: