Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #2246

Merged
merged 2 commits into from
May 17, 2023
Merged

Fix typo #2246

merged 2 commits into from
May 17, 2023

Conversation

ZjuYTW
Copy link
Contributor

@ZjuYTW ZjuYTW commented May 14, 2023

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):

Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

ZjuYTW added 2 commits May 14, 2023 18:26
@ZjuYTW
Fix typo
bdddd1c 
Signed-off-by: wangyitao <wangyitao999@outlook.com>
@ZjuYTW
Fix more
11c4372 
Signed-off-by: wangyitao <wangyitao999@outlook.com>
@TousakaRin
Copy link
Contributor

thanks, 可以把两个commit合并成一个吗

@chenBright
Copy link
Contributor

thanks, 可以把两个commit合并成一个吗

”Squash and merge“就好了吧

@TousakaRin TousakaRin merged commit bfb26a1 into apache:master May 17, 2023
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
@ZjuYTW
Fix typo (apache#2246)
8885b97 
* Fix typo

---------

Signed-off-by: wangyitao <wangyitao999@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZjuYTW @TousakaRin @chenBright