-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert consul naming service #2129
Conversation
CI重试之后还是失败,看起来和代码改动无关 |
master修复了CI失败,可以rebase一下 |
CI是不是还有问题?我本地跑是可以过的,但是CI跑了几次,都是core在这个地方。
|
看上去似乎和改动有关 |
是的,现在好了。git commit不太整洁,合的时候需要square一下。 |
* revert consul naming service * revert consul naming service * revert consul naming service
* revert consul naming service * revert consul naming service * revert consul naming service
What problem does this PR solve?
Issue Number: #2123
Problem Summary:
ConsulNamingService其实不是PeriodicNamingService,不是简单的轮询,而是长轮询,每次rpc成功后,立即发起下一次长轮询。只有失败了,才会sleep。
Blocking Queries:
What is changed and the side effects?
Changed:
回退#2123 ConsulNamingService的改动
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: