New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TCP heartbeat of client #2098

Merged

wwbmmm merged 5 commits into apache:master from chenBright:keepalive

Apr 26, 2023

Contributor

chenBright commented Jan 26, 2023

What problem does this PR solve?

Issue Number: #1895

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):

Check List:

Please make sure your changes are compilable(请确保你的更改可以通过编译).
When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

wwbmmm reviewed

View reviewed changes

src/brpc/socket.cpp Outdated Show resolved Hide resolved

src/brpc/socket.h Outdated Show resolved Hide resolved

src/brpc/input_messenger.cpp Outdated Show resolved Hide resolved

Contributor

wwbmmm commented Jan 28, 2023

另外补充一下单测？

chenguangming added 2 commits

January 28, 2023 22:34


          support TCP heartbeat of client

0c4ad71


          optimize keepalive code & add UT

3dacaa5

chenBright force-pushed the keepalive branch from 9cff55b to 3dacaa5 Compare

January 30, 2023 13:20

Contributor Author

chenBright commented Jan 30, 2023

另外补充一下单测？

done

wwbmmm reviewed

View reviewed changes

src/brpc/socket.h Outdated Show resolved Hide resolved

src/brpc/socket.h Outdated Show resolved Hide resolved

cdjingit reviewed

View reviewed changes

src/brpc/socket.cpp Outdated Show resolved Hide resolved

cdjingit reviewed

View reviewed changes

src/brpc/socket.cpp Show resolved Hide resolved

cdjingit reviewed

View reviewed changes

src/brpc/socket.cpp Outdated Show resolved Hide resolved

cdjingit reviewed

View reviewed changes

src/brpc/socket.cpp Outdated Show resolved Hide resolved

cdjingit reviewed

View reviewed changes

src/brpc/socket.cpp Outdated Show resolved Hide resolved

cdjingit reviewed

View reviewed changes

src/brpc/socket.cpp Outdated Show resolved Hide resolved

cdjingit reviewed

View reviewed changes

src/brpc/socket.h Outdated Show resolved Hide resolved

chenguangming added 2 commits

January 31, 2023 20:03


          optimize keepalive code

64ba10b


          fix keepalive UT

21ba918

chenBright force-pushed the keepalive branch from f53886f to 21ba918 Compare

January 31, 2023 12:43


          use PLOG instead of LOG

8e8e596

Contributor

wwbmmm commented Feb 2, 2023

LGTM

1 similar comment

Contributor

cdjingit commented Feb 2, 2023

LGTM

chenBright changed the title ~~support TCP heartbeat of client~~ Support TCP heartbeat of client

chenBright added the feature label

wwbmmm merged commit ec11bb3 into apache:master

chenBright deleted the keepalive branch

April 26, 2023 08:18

yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request


          Support TCP heartbeat of client (apache#2098)

fff6fcf

* support TCP heartbeat of client

* optimize keepalive code & add UT

* optimize keepalive code

* fix keepalive UT

* use PLOG instead of LOG

yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request


          Support TCP heartbeat of client (apache#2098)

a59983e

* support TCP heartbeat of client

* optimize keepalive code & add UT

* optimize keepalive code

* fix keepalive UT

* use PLOG instead of LOG

wwbmmm mentioned this pull request

brpc故障恢复bug #2146

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature