Fix butex wait_pthread handle EINTR #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwbmmm
reviewed
Jan 16, 2023
jenrryyou
force-pushed
the
fix_butex_wait_pthread_handle
branch
from
4d84f91 to
10dc7a2
Compare
wwbmmm
reviewed
Jan 23, 2023
wasphin
reviewed
Jan 24, 2023
jenrryyou
force-pushed
the
fix_butex_wait_pthread_handle
branch
from
10dc7a2 to
5ed13f8
Compare
|
LGTM |
|
能为这种情况增加一个单测么？（bthread的修改可能影响面很大） |
加了一个单测ButexTest.wait_with_signal_triggered，在这个修复之前是会稳定断言失败 |
jenrryyou
force-pushed
the
fix_butex_wait_pthread_handle
branch
2 times, most recently
from
92288de to
7d67145
Compare
jenrryyou
force-pushed
the
fix_butex_wait_pthread_handle
branch
from
7d67145 to
3431c19
Compare
|
@chenBright 可以帮忙重跑下clang-unittest吗~ 我看了失败的SocketTest.keepalive_input_message的逻辑跟butex无关，本地重跑也是可以通过的，怀疑是这个test case不稳定 |
done |
yanglimingcn
pushed a commit
to yanglimingcn/brpc
that referenced
this pull request
Jun 25, 2023
yanglimingcn
pushed a commit
to yanglimingcn/brpc
that referenced
this pull request
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wait_pthread处理被信号中断的情况。
没有这个处理之前，假设butex_wait_from_pthread的timeout设置为100s，但是这个线程每隔10s会被信号中断（如正在进行profile，会定时中断采集线程堆栈），futex_wait_private会返回EINTR，导致butex_wait_from_pthread永远不会超时返回。