Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix HTTP invalid host issue for channel not inited by http(s) #1973

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

thorneliu
Copy link
Contributor

What problem does this PR solve?

Issue Number:
#1940

Problem Summary:
Invalid host in HTTP header if setting host via service_name for channel inited by list or file

What is changed and the side effects?

Changed:
check if ns_url shceme is 'http' or 'https', if true, set host field by service_name

Side effects:

  • Performance effects(性能影响):
    NO impact
  • Breaking backward compatibility(向后兼容性):
    NO impact

Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

tanzhongyi003 pushed a commit to tanzhongyi003/incubator-brpc that referenced this pull request Oct 29, 2022
Co-authored-by: XiguoHu <huxiguo@baidu.com>
@wwbmmm
Copy link
Contributor

wwbmmm commented Oct 31, 2022

LGTM

@wwbmmm wwbmmm merged commit 3f8e1cc into apache:master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants