fix: domain name length #1965
Merged
fix: domain name length #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwbmmm
reviewed
Oct 26, 2022
| // and RFC 5892. The full domain name may not exceed the length of 253 characters in its textual representation | ||
| // (Domain Names - Domain Concepts and Facilities. IETF. doi:10.17487/RFC1034. RFC 1034.). | ||
| // For cacheline optimize, use buf size as 256; | ||
| char buf[256]; |
There was a problem hiding this comment.
建议加个static_assert
MAX_DOMAIN_LENGTH < sizeof(buf)
|
建议补充一下边界值的单测 |
这里有个麻烦的地方在于我没有一个可用的足够长的域名，导致我的返回值无论正确错误都是 -1 的。 |
可以，或者返回-1，并设置errno |
|
@wayslog remind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #1911
Problem Summary: hostname2endpoint implement is not compatite with domain RFCs.
What is changed and the side effects?
Changed: change the buf length as 256, and use MAX_DOMAIN_LENGTH to check the domain name valid. But I don't have an exists domain to test it.
Side effects:
Performance effects(性能影响): hostname2endpoint will allocate more 192 byte memory in stack.
Breaking backward compatibility(向后兼容性): yes
Check List: