fix_share_tls_block #1156
Merged
fix_share_tls_block #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gydong
reviewed
Jul 8, 2020
| new_block = b; | ||
| while (new_block && new_block->full()) { | ||
| IOBuf::Block* const saved_next = new_block->portal_next; | ||
| new_block->dec_ref(); |
There was a problem hiding this comment.
出现new_block->full的场景是什么？可以补充UT么？
There was a problem hiding this comment.
一个可能的场景是：
1）不断调IOBuf::push_back(c)，它的实现是拿到tls head block，然后在下一个位置将c写进入，假设当前的c写入后使得该block变满
2）某处调用release_tls_block或者release_tls_block_chain，把某个block b2还给tls，此时tls的数据是b2 -> b(之前那块满的）
3）继续调IOBuf::push_back，写到了b2后面，b2满后，会拿b2的next block返回，此时没有判断full，就把b返回了
4）IOBuf::push_back往一个满的block中写入数据
对应的UT加好了，这个UT在原来的代码上跑会挂
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.