Rename

src/brpc/socket.cpp

@@ -541,6 +541,10 @@ int Socket::ResetFileDescriptor(int fd) {
     if (!ValidFileDescriptor(fd)) {
         return 0;
     }
+    if (_remote_side == butil::EndPoint()) {
+        // OK to fail, non-socket fd does not support this.
+        butil::get_remote_side(fd, &_remote_side);
+    }
     // OK to fail, non-socket fd does not support this.
     if (butil::get_local_side(fd, &_local_side) != 0) {
         _local_side = butil::EndPoint();
@@ -748,8 +752,8 @@ int Socket::Create(const SocketOptions& options, SocketId* id) {
     CHECK(NULL == m->_write_head.load(butil::memory_order_relaxed));
     int fd = options.fd;
     if (!m->ValidFileDescriptor(fd) && options.connect_on_create) {
-        // Connect on created.
-        fd = m->DoConnect(options.abstime, NULL, NULL);
+        // Connect on create.
+        fd = m->DoConnect(options.connect_abstime, NULL, NULL);
         if (fd < 0) {
             PLOG(ERROR) << "Fail to connect to " << options.remote_side;
             int error_code = errno != 0 ? errno : EHOSTDOWN;

src/brpc/socket.h

@@ -200,12 +200,12 @@ struct SocketOptions {
     butil::EndPoint remote_side;
     // If `connect_on_create' is true and `fd' is less than 0,
     // a client connection will be established to remote_side()
-    // regarding deadline `abstime' when Socket is being created.
+    // regarding deadline `connect_abstime' when Socket is being created.
     // Default: false, means that a connection will be established
     // on first write.
     bool connect_on_create;
     // Default: NULL, means no timeout.
-    const timespec* abstime;
+    const timespec* connect_abstime;
     SocketUser* user;
     // When *edge-triggered* events happen on the file descriptor, callback
     // `on_edge_triggered_events' will be called. Inside the callback, user

src/brpc/socket_inl.h

@@ -55,7 +55,7 @@ BUTIL_FORCE_INLINE uint64_t MakeVRef(uint32_t version, int32_t nref) {
 inline SocketOptions::SocketOptions()
     : fd(-1)
     , connect_on_create(false)
-    , abstime(NULL)
+    , connect_abstime(NULL)
     , user(NULL)
     , on_edge_triggered_events(NULL)
     , health_check_interval_s(-1)

test/brpc_ssl_unittest.cpp

@@ -244,7 +244,7 @@ void ProcessResponse(brpc::InputMessageBase* msg_base) {
     ASSERT_EQ(0, bthread_id_unlock_and_destroy(cid));
 }
 
-TEST_F(SSLTest, fd_ssl) {
+TEST_F(SSLTest, connect_on_create) {
     brpc::Protocol dummy_protocol = {
         brpc::policy::ParseRpcMessage, brpc::SerializeRequestDefault,
         brpc::policy::PackRpcRequest,NULL, ProcessResponse,