fix wrong implementation for percentile in bookkeeper-benchmark
#3864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3864 +/- ##
=============================================
- Coverage 65.25% 39.84% -25.41%
+ Complexity 6504 3943 -2561
=============================================
Files 473 473
Lines 40987 40987
Branches 5243 5243
=============================================
- Hits 26745 16332 -10413
- Misses 12040 22894 +10854
+ Partials 2202 1761 -441
Flags with carried forward coverage won't be shown. Click here to find out more. see 267 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shoothzj
approved these changes
Apr 9, 2024
|
Sorry for my late reply, Could you please rebase the master code? There may has some flaky tests. |
According to `https://stackoverflow.com/questions/12808934/what-is-p99-latency`, the implementation for `percentile` in bookkeeper-benchmark is wrong. Co-authored-by: ZhangJian He <shoothzj@gmail.com> Signed-off-by: ZhangJian He <shoothzj@gmail.com>
shoothzj
force-pushed
the
fix_benchmark_percentile
branch
from
f5cd426 to
8e96008
Compare
|
@trevor211 Thanks for your contribution, looking forward to your future contributions. :) |
shoothzj
pushed a commit
that referenced
this pull request
May 25, 2024
) According to `https://stackoverflow.com/questions/12808934/what-is-p99-latency`, the implementation for `percentile` in bookkeeper-benchmark is wrong. Signed-off-by: ZhangJian He <shoothzj@gmail.com> Co-authored-by: ZhangJian He <shoothzj@gmail.com> (cherry picked from commit 55ffbd7)
shoothzj
pushed a commit
that referenced
this pull request
May 25, 2024
) According to `https://stackoverflow.com/questions/12808934/what-is-p99-latency`, the implementation for `percentile` in bookkeeper-benchmark is wrong. Signed-off-by: ZhangJian He <shoothzj@gmail.com> Co-authored-by: ZhangJian He <shoothzj@gmail.com> (cherry picked from commit 55ffbd7)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…ache#3864) According to `https://stackoverflow.com/questions/12808934/what-is-p99-latency`, the implementation for `percentile` in bookkeeper-benchmark is wrong. Signed-off-by: ZhangJian He <shoothzj@gmail.com> Co-authored-by: ZhangJian He <shoothzj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to
https://stackoverflow.com/questions/12808934/what-is-p99-latency, the implementation forpercentilein bookkeeper-benchmark is wrong.Descriptions of the changes in this PR:
Motivation
When I did benchmark tests using bookeeper-benchmark, I found that the percentile output seemed wrong. After checking the source code I think the current implementation is wrong.
Changes
Fix function
percentilein bookkeeper-benchmark to make it corrent.