Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the request in the stream python client dependency #2754

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

zymap
Copy link
Member

@zymap zymap commented Jul 15, 2021


Master Issue: #2752

Motivation

As discussed at length in https://issues.apache.org/jira/browse/LEGAL-572
we found out that the chardet library used by requests library was a
mandatory dependency to requests and since it has LGPL licence, we
should not release any Apache Software with it.

---

Master Issue: apache#2752

*Motivation*

As discussed at length in https://issues.apache.org/jira/browse/LEGAL-572
we found out that the chardet library used by requests library was a
mandatory dependency to requests and since it has LGPL licence, we
should not release any Apache Software with it.
@zymap zymap requested review from sijie and eolivelli July 15, 2021 02:02
@zymap zymap self-assigned this Jul 15, 2021
@zymap
Copy link
Member Author

zymap commented Jul 19, 2021

Hi @eolivelli, Looks like the required lib is not necessary for us. We can remove it by this PR

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zymap
Copy link
Member Author

zymap commented Aug 16, 2021

@eolivelli Should we include this PR into the 4.14.2 release?

Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
)

---

Master Issue: apache#2752

*Motivation*

As discussed at length in https://issues.apache.org/jira/browse/LEGAL-572
we found out that the chardet library used by requests library was a
mandatory dependency to requests and since it has LGPL licence, we
should not release any Apache Software with it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants