Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Java11 test fix #32209

Merged
merged 2 commits into from
Aug 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/beam_PostCommit_Go_VR_Samza.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,11 @@ jobs:
comment_phrase: ${{ matrix.job_phrase }}
github_token: ${{ secrets.GITHUB_TOKEN }}
github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
- name: Setup environment
uses: ./.github/actions/setup-environment-action
# TODO(https://github.com/apache/beam/issues/32208) move to Java11 after bump to Samza 1.8
with:
java-version: 8
- name: run Go Samza ValidatesRunner script
env:
CLOUDSDK_CONFIG: ${{ env.KUBELET_GCLOUD_CONFIG_PATH}}
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/beam_PostCommit_Java_PVR_Samza.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,20 @@ jobs:
github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
- name: Setup environment
uses: ./.github/actions/setup-environment-action
# TODO(https://github.com/apache/beam/issues/32208) move to Java11 after bump to Samza 1.8
with:
java-version: |
8
11
- name: run PostCommit Java Samza script
env:
CLOUDSDK_CONFIG: ${{ env.KUBELET_GCLOUD_CONFIG_PATH}}
uses: ./.github/actions/gradle-command-self-hosted-action
with:
gradle-command: :runners:samza:job-server:validatesPortableRunner
arguments: |
-PtestJavaVersion=8 \
-Pjava8Home=$JAVA_HOME_8_X64 \
- name: Archive JUnit Test Results
uses: actions/upload-artifact@v4
if: ${{ !success() }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,18 @@ jobs:
github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
- name: Setup environment
uses: ./.github/actions/setup-environment-action
# TODO(https://github.com/apache/beam/issues/32208) move to Java11 after bump to Samza 1.8
with:
java-version: default
java-version: |
8
11
- name: run validatesRunner script
uses: ./.github/actions/gradle-command-self-hosted-action
with:
gradle-command: :runners:samza:validatesRunner
arguments: |
-PtestJavaVersion=8 \
-Pjava8Home=$JAVA_HOME_8_X64 \
- name: Archive JUnit Test Results
uses: actions/upload-artifact@v4
if: ${{ !success() }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,9 @@ jobs:
github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }} ${{ matrix.python_version }})
- name: Setup environment
uses: ./.github/actions/setup-environment-action
# TODO(https://github.com/apache/beam/issues/32208) move to Java11 after bump to Samza 1.8
with:
java-version: default
java-version: 8
python-version: ${{ matrix.python_version }}
- name: Set PY_VER_CLEAN
id: set_py_ver_clean
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/beam_PostCommit_XVR_Samza.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,9 @@ jobs:
github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }} ${{ matrix.python_version }})
- name: Setup environment
uses: ./.github/actions/setup-environment-action
# TODO(https://github.com/apache/beam/issues/32208) move to Java11 after bump to Samza 1.8
with:
java-version: 8
python-version: |
3.8
${{ matrix.python_version }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ jobs:
-PdisableCheckStyle=true \
-Dfile.encoding=UTF-8 \
-PtestJavaVersion=8 \
-Pjava17Home=$JAVA_HOME_8_X64 \
-Pjava8Home=$JAVA_HOME_8_X64 \
- name: Archive JUnit Test Results
uses: actions/upload-artifact@v4
if: ${{ !success() }}
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/beam_PreCommit_Java_IOs_Direct.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,10 @@ jobs:
github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
- name: Setup environment
uses: ./.github/actions/setup-environment-action
java-version: |
8
11
with:
java-version: |
8
11
- name: run Java IOs PreCommit script
uses: ./.github/actions/gradle-command-self-hosted-action
with:
Expand All @@ -107,7 +108,7 @@ jobs:
-PdisableCheckStyle=true \
-Dfile.encoding=UTF-8 \
-PtestJavaVersion=8 \
-Pjava17Home=$JAVA_HOME_8_X64 \
-Pjava8Home=$JAVA_HOME_8_X64 \
- name: Archive JUnit Test Results
uses: actions/upload-artifact@v4
if: ${{ !success() }}
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/beam_PreCommit_Java_Spark3_Versions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,18 @@ jobs:
- name: Setup environment
uses: ./.github/actions/setup-environment-action
with:
java-version: default
java-version: |
8
11
# TODO(https://github.com/apache/beam/issues/32207) Run test with Java11
- name: run sparkVersionsTest script
uses: ./.github/actions/gradle-command-self-hosted-action
with:
gradle-command: :runners:spark:3:sparkVersionsTest
arguments: -PdisableSpotlessCheck=true
arguments: |
-PdisableSpotlessCheck=true \
-PtestJavaVersion=8 \
-Pjava8Home=$JAVA_HOME_8_X64 \
- name: Archive JUnit Test Results
uses: actions/upload-artifact@v4
if: ${{ !success() }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2581,7 +2581,9 @@ class BeamModulePlugin implements Plugin<Project> {
// see https://issues.apache.org/jira/browse/BEAM-6698
maxHeapSize = '4g'
if (config.environment == PortableValidatesRunnerConfiguration.Environment.DOCKER) {
dependsOn ':sdks:java:container:java8:docker'
def ver = project.findProperty('testJavaVersion')
def javaContainerSuffix = ver ? "java$ver" : getSupportedJavaVersion()
dependsOn ":sdks:java:container:${javaContainerSuffix}:docker"
}
}
}
Expand Down
Loading