-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go SDK: GCS FS supports rename, improved test coverage. Local FS supports copy. #26065
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26065 +/- ##
==========================================
+ Coverage 71.18% 71.21% +0.03%
==========================================
Files 787 787
Lines 103298 103330 +32
==========================================
+ Hits 73528 73588 +60
+ Misses 28288 28245 -43
- Partials 1482 1497 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
assign to next reviewer |
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Run GoPortable PreCommit |
Run Go PreCommit |
Run GoPortable PreCommit |
Run RAT PreCommit |
Run Whitespace PreCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM mod the change to CHANGES.md. I'll merge when that's updated. Thank you!
Updated the |
Rebased with latest changes and reran |
I don't think Jenkins picked up the precommits for some reason, let me see if I can get it to run... |
retest this please |
Thank you for your contribution and your patience while we got everything tested! |
Fixes #26064
All changes are for the Go SDK.
github.com/fsouza/fake-gcs-server/fakestorage
.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.