Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anchor link for the logo wall #25594

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Add anchor link for the logo wall #25594

merged 1 commit into from
Feb 22, 2023

Conversation

aaltay
Copy link
Member

@aaltay aaltay commented Feb 22, 2023

With this change, we can link to the logo wall directly as: https://beam.apache.org/case-studies/#logos -- otherwise it is easy to miss because the logos are below the fold.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@damccorm
Copy link
Contributor

retest this please

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like to get checks running before merging

@aaltay
Copy link
Member Author

aaltay commented Feb 22, 2023

Do you know why tests did not run until you add the retest comment?

@damccorm
Copy link
Contributor

I'm not sure - Jenkins has been a little slow today. We may have just needed to give it a few minutes

@damccorm damccorm merged commit 93c1e92 into master Feb 22, 2023
lostluck pushed a commit to lostluck/beam that referenced this pull request Feb 22, 2023
ruslan-ikhsan pushed a commit to akvelon/beam that referenced this pull request Mar 10, 2023
cushon pushed a commit to cushon/beam that referenced this pull request Mar 16, 2023
@aaltay aaltay deleted the aaltay-patch-1 branch June 9, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants