Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade container cryptography version to avoid yanked version #23711

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Oct 18, 2022

gradle task :sdks:python:container:xx:docker now show warnings:

WARNING: The candidate selected for download or install is a yanked version: 'cryptography' candidate (version 38.0.2 at https://files.pythonhosted.org/packages/56/1e/2ffbbdddfe17308511cb2e06ac8c5aced9391dd5eea339e330a204edac34/cryptography-38.0.2-cp36-abi3-manylinux_2_28_x86_64.whl (from https://pypi.org/simple/cryptography/) (requires-python:>=3.6))
16:10:52 Reason for being yanked: Regression in OpenSSL.

after #23587 in. Since we are close to another release cut. Better to get this in so we do not include. yanked version on released container.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@Abacn
Copy link
Contributor Author

Abacn commented Oct 18, 2022

R: @tvalentyn
R: @AnandInguva

Copy link
Contributor

@AnandInguva AnandInguva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting this warning. Thanks for the quick fix.

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #23711 (f3333fe) into master (fef5ea9) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #23711   +/-   ##
=======================================
  Coverage   73.32%   73.33%           
=======================================
  Files         719      719           
  Lines       95802    95802           
=======================================
+ Hits        70249    70252    +3     
+ Misses      24242    24239    -3     
  Partials     1311     1311           
Flag Coverage Δ
python 83.04% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../python/apache_beam/transforms/periodicsequence.py 98.38% <0.00%> (-1.62%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) ⬇️
...eam/runners/interactive/caching/streaming_cache.py 96.66% <0.00%> (+1.25%) ⬆️
...che_beam/runners/interactive/interactive_runner.py 91.77% <0.00%> (+1.26%) ⬆️
sdks/python/apache_beam/utils/interactive_utils.py 97.56% <0.00%> (+2.43%) ⬆️
.../python/apache_beam/testing/test_stream_service.py 92.85% <0.00%> (+4.76%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tvalentyn
Copy link
Contributor

LGTM

@tvalentyn
Copy link
Contributor

error is unrelated:

 1654 > Task :sdks:java:fn-execution:compileJava                                      
 1655 warning: Memory constraints are impeding performance; please increase max heap size.
 1656 warning: Memory constraints are impeding performance; please increase max heap size.
 1657 error: warnings found and -Werror specified      

@tvalentyn
Copy link
Contributor

Run PythonDocker PreCommit passed.

@tvalentyn tvalentyn merged commit bf9f610 into apache:master Oct 18, 2022
@Abacn Abacn deleted the yankedversion branch October 18, 2022 22:44
@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants