-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow BigQuery TableIds to have space in between #22167
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22167 +/- ##
==========================================
- Coverage 74.22% 74.20% -0.02%
==========================================
Files 702 702
Lines 92829 92830 +1
==========================================
- Hits 68904 68887 -17
- Misses 22658 22676 +18
Partials 1267 1267
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Assigning reviewers. If you would like to opt out of this review, comment R: @pabloem for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good.
Technically \s is broader than Zs, but I don't see a good way to make that distinction with Python's re module, and false positives here are preferable to false negatives.
Thanks for the review! |
Thanks, @dgdheeraj ! |
* Updated Regex and test * Updated Regex and test
For Issue #21878
io.Bigquery rejects valid tableIds if they contain spaces.:
However these are allowed by the BigQuery API:
https://cloud.google.com/bigquery/docs/tables#table_naming
If tableId includes hyphens, causes this error
FIX:
The regex is modified to allow spaces only in between the word and not allow trailing/leading spaces
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.
It's my first attempt contributing to beam.
Please do let me know if there are any further changes/issues with the PR
@pabloem
@kennknowles
@robertwb