[BEAM-12482] Respect schemaUpdateOptions during BigQuery load with temporary tables #16303
Conversation
|
Run Java PostCommit |
|
Run Java PreCommit |
2 similar comments
|
Run Java PreCommit |
|
Run Java PreCommit |
|
R: @chamikaramj Hi, I'm working on a fix for https://issues.apache.org/jira/browse/BEAM-12482 that I see you were commenting on, could you give it a review or know who can do it? The PR is an attempt to replicate the fix done in #14113 for python. |
|
@chamikaramj - Could you please review this change? |
|
R: @pabloem |
|
|
||
| String[] values = {"meow", "bark"}; | ||
| TableRow rowToInsert = | ||
| new TableRow().set("new_field", values[0]).set("required_field", values[1]); |
There was a problem hiding this comment.
is a single row enough to cause two loads to happen? Can we please add another Row so that we can force a two-stage load?
|
@MiguelAnzoWizeline - could you please respond to open comments? |
Hi @aaltay! @MiguelAnzoWizeline is no longer in our team. |
Ack. Thank you. Good luck @MiguelAnzoWizeline and thank you for everything :) And we are all Beam contributors, you are all always welcome here. |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
@fernando-wizeline do we have plans for this PR? |
Hi @pabloem! |
Hi @pabloem I already finished the changes I will be submitting a new PR with the changes on this fix, I am just pulling the tests since the new changes and flow affected the tests on BigQuerySchemaUpdateOptionsIT. |
|
Link to the new PR-17365, this PR can be closed, since it will no longer be needed. |
Adding a zero row job to bigquery writeTable to update the schema when using temporary tables
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.