Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-10904: [Python][CI][Packaging] Add support for Python 3.9 macOS wheels #8915

Closed
wants to merge 1 commit into from
Closed

ARROW-10904: [Python][CI][Packaging] Add support for Python 3.9 macOS wheels #8915

wants to merge 1 commit into from

Conversation

terencehonles
Copy link
Contributor

Picking back up from #8386 in case I can handle this or someone else wants to work off of it.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-10904

@kou kou mentioned this pull request Dec 30, 2020
Closed
@terencehonles
Copy link
Contributor Author

@github-actions crossbow submit wheel-osx-*-cp39

@terencehonles
Copy link
Contributor Author

@kou / @kszucs you may already know but it looks like the crossbow submitter / github actions bot isn't working(?). It doesn't look like multibuild has tasks for GitHub Actions, but I wanted to see how far the Travis OS X commands would get.

@kszucs
Copy link
Member

kszucs commented Jan 5, 2021

Yes, the comment bot seems to be failing https://github.com/apache/arrow/actions/runs/462228610
This is most likely caused by the recent security changes, so we need to update the comment_bot.yml action to use verified plugins only.

@terencehonles
Copy link
Contributor Author

@kszucs I noticed there was a list of allowed actions. Could the allow list just be updated or is that enforced at the apache (org) level rather than the repo level?

@kszucs
Copy link
Member

kszucs commented Jan 5, 2021

I'm afraid that it is enforced at organization level, so we need to update that action.

@kszucs
Copy link
Member

kszucs commented Jan 5, 2021

Should be fixed by #9103

@kszucs
Copy link
Member

kszucs commented Jan 5, 2021

@github-actions crossbow submit wheel-osx-*-cp39

@github-actions
Copy link

github-actions bot commented Jan 5, 2021

Revision: 6f13c4c

Submitted crossbow builds: ursa-labs/crossbow @ actions-823

Task Status
wheel-osx-high-sierra-cp39 Github Actions
wheel-osx-mavericks-cp39 Github Actions

@terencehonles
Copy link
Contributor Author

Should be fixed by #9103

Thanks @kszucs !

@terencehonles terencehonles mentioned this pull request Jan 5, 2021
Closed
@terencehonles
Copy link
Contributor Author

@github-actions crossbow submit wheel-osx-*-cp39

@github-actions
Copy link

github-actions bot commented Jan 5, 2021

Revision: 28c36b4

Submitted crossbow builds: ursa-labs/crossbow @ actions-826

Task Status
wheel-osx-high-sierra-cp39 Github Actions
wheel-osx-mavericks-cp39 Github Actions

@terencehonles terencehonles changed the title ARROW-10904: [Python] Add support for Python 3.9 macOS wheels ARROW-10904: [Python][CI][Packaging] Add support for Python 3.9 macOS wheels Jan 5, 2021
@terencehonles
Copy link
Contributor Author

@github-actions crossbow submit -g conda -g wheel

@github-actions
Copy link

github-actions bot commented Jan 6, 2021

Revision: 28c36b4

Submitted crossbow builds: ursa-labs/crossbow @ actions-827

Task Status
conda-clean Azure
conda-linux-gcc-py36-aarch64 Drone
conda-linux-gcc-py36-cpu-r36 Azure
conda-linux-gcc-py36-cuda Azure
conda-linux-gcc-py37-aarch64 Drone
conda-linux-gcc-py37-cpu-r40 Azure
conda-linux-gcc-py37-cuda Azure
conda-linux-gcc-py38-aarch64 Drone
conda-linux-gcc-py38-cpu Azure
conda-linux-gcc-py38-cuda Azure
conda-linux-gcc-py39-aarch64 Drone
conda-linux-gcc-py39-cpu Azure
conda-linux-gcc-py39-cuda Azure
conda-osx-clang-py36-r36 Azure
conda-osx-clang-py37-r40 Azure
conda-osx-clang-py38 Azure
conda-osx-clang-py39 Azure
conda-win-vs2017-py36-r36 Azure
conda-win-vs2017-py37-r40 Azure
conda-win-vs2017-py38 Azure
wheel-manylinux1-cp36m Azure
wheel-manylinux1-cp37m Azure
wheel-manylinux1-cp38 Azure
wheel-manylinux1-cp39 Azure
wheel-manylinux2010-cp36m Azure
wheel-manylinux2010-cp37m Azure
wheel-manylinux2010-cp38 Azure
wheel-manylinux2010-cp39 Azure
wheel-manylinux2014-cp36m Azure
wheel-manylinux2014-cp37m Azure
wheel-manylinux2014-cp38 Azure
wheel-manylinux2014-cp39 Azure
wheel-osx-high-sierra-cp36m Github Actions
wheel-osx-high-sierra-cp37m Github Actions
wheel-osx-high-sierra-cp38 Github Actions
wheel-osx-high-sierra-cp39 Github Actions
wheel-osx-mavericks-cp36m Github Actions
wheel-osx-mavericks-cp37m Github Actions
wheel-osx-mavericks-cp38 Github Actions
wheel-osx-mavericks-cp39 Github Actions
wheel-win-cp36m Github Actions
wheel-win-cp37m Github Actions
wheel-win-cp38 Github Actions

@terencehonles
Copy link
Contributor Author

@kou not sure if you might have a chance to review the PR, it looks like the change to GitHub actions seems to be working.

kou
kou approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Great!

dev/tasks/python-wheels/github.osx.yml Outdated
run_import_tests

# restore the original Cellar
CELLAR=$(brew --cellar)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this because we already have CELLER=?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks

@kou kou closed this in 73e5097 Jan 6, 2021
@kou
Copy link
Member

kou commented Jan 6, 2021

Thanks!

@nealrichardson
Copy link
Member

FWIW I have a mac with macOS 10.14 and I confirmed that I can install the high sierra wheel that this produced.

@terencehonles
Copy link
Contributor Author

FWIW I have a mac with macOS 10.14 and I confirmed that I can install the high sierra wheel that this produced.

Thanks, hopefully this made the cut for the next release and there are no issues with the build system changing 🙂

@terencehonles terencehonles deleted the arrow-10904 branch January 6, 2021 21:26
@aberres
Copy link

aberres commented Jan 18, 2021

Great work, looking forward to get this released!

Thanks, hopefully this made the cut for the next release and there are no issues with the build system changing 🙂

Is there any place where one can find a release schedule?

@kszucs
Copy link
Member

kszucs commented Jan 18, 2021

You can follow the release process on the development mailing list (https://arrow.apache.org/community/).

@mafrosis
Copy link

Glad to see this is coming. What date will the wheel be available?

@aberres
Copy link

aberres commented Jan 19, 2021

Glad to see this is coming. What date will the wheel be available?

An RC for 3.0 is on its way. See https://lists.apache.org/list.html?dev@arrow.apache.org

@mafrosis
Copy link

mafrosis commented Jan 19, 2021 •
edited
Loading

Ah thanks for that, but I wasn't looking for PyArrow 3; I was hoping for a built wheel of 2.0.0 for Python 3.9 on macos.

I think safest for now to tell my users Python 3.9 is unsupported 😄

@angela97lin angela97lin mentioned this pull request Jan 22, 2021
Closed
@aberres
Copy link

aberres commented Jan 27, 2021

Downloading pyarrow-3.0.0-cp39-cp39-macosx_10_13_x86_64.whl (14.2 MB)

Yay, thanks!

GeorgeAp pushed a commit to sirensolutions/arrow that referenced this pull request Jun 7, 2021
@terencehonles @GeorgeAp
ARROW-10904: [Python][CI][Packaging] Add support for Python 3.9 macOS…
04dd376 
… wheels

Picking back up from apache#8386 in case I can handle this or someone else wants to work off of it.

Closes apache#8915 from terencehonles/arrow-10904

Authored-by: Terence D. Honles <terence@honles.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@asfimport asfimport mentioned this pull request Jan 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@terencehonles @kszucs @kou @nealrichardson @aberres @mafrosis