Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Type checking with mypy #6301

Closed
wants to merge 1 commit into from
Closed

WIP: Type checking with mypy #6301

wants to merge 1 commit into from

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Jan 28, 2020

First iteration to have type hints. I have found some problems using them, I'll adress those in separate PRs but I will leave the type hints itself here as an FYI and will rebase continuously until we have dropped Py2 so that we can use inline hints.

To make real use of mypy, we would need stubs for the Cython based modules, this depends on someone implementing a pyi generator for Cython, see also cython/cython#3150.

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@wesm
Copy link
Member

wesm commented Mar 19, 2020

Seems like rehabilitating this and adding mypy to our CI would be useful soon

@xhochy
Copy link
Member Author

xhochy commented Mar 19, 2020

My main issue holding this back is that I remember that we don't wanted to break 2.7 hard in the source code. Adding type hints and check to pyarrow would be much simpler when we could use 3.6+ syntax.

I'm still from time to time fixing bits that popped up during this work as separate PRs.

@nealrichardson
Copy link
Member

We did remove 2.7 support already, so maybe that's not a concern anymore?

@xhochy
Copy link
Member Author

xhochy commented Mar 23, 2020

Split this up and made a first round in #6676

@wesm
Copy link
Member

wesm commented May 24, 2020

Closing this since the work is being divided into separate PRs

@wesm wesm closed this May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants