GH-44111: [CI][Python] Enable S3 tests on macOS CI #44129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pitrou
force-pushed
the
gh44111-py-macos-tests
branch
from
b2deec8
to
7a75b3a
Compare
pitrou
changed the title
|
@github-actions crossbow submit wheel-macos* |
|
Revision: dfc79d8 Submitted crossbow builds: ursacomputing/crossbow @ actions-575374bf24
|
pitrou
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
kou
approved these changes
Sep 16, 2024
github-actions
bot
added
awaiting merge
|
@github-actions crossbow submit wheel-macos* |
|
Revision: a4b52d7 Submitted crossbow builds: ursacomputing/crossbow @ actions-0dd60e1229
|
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 3600db8. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
S3 support is enabled when building PyArrow for macOS (both on PR builds and in Crossbow wheel builds), but minio wan't installed before testing, therefore S3 support in PyArrow was not tested at all.
What changes are included in this PR?
Ensure Minio is installed before running PyArrow tests on macOS builds.
Are these changes tested?
Yes, by construction.
Are there any user-facing changes?
No.