GH-43883: [CI] Remove Python version guard when installing GCS testbench #43884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@github-actions crossbow submit wheel-manylinux-2014-cp38-amd64 wheel-manylinux-2014-cp38-arm64 wheel-manylinux-2014-cp313-amd64 wheel-manylinux-2014-cp313-arm64 wheel-macos-big-sur-cp38-arm64 wheel-macos-big-sur-cp313-arm64 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
pitrou
force-pushed
the
gh43883-gcs-testbench-py-version
branch
from
8fc4c1d
to
d8cd7cf
Compare
|
@github-actions crossbow submit wheel-macos-big-sur-cp38-arm64 wheel-macos-big-sur-cp313-arm64 wheel-macos-catalina-cp38-amd64 wheel-macos-catalina-cp313-amd64 |
This comment was marked as outdated.
This comment was marked as outdated.
pitrou
force-pushed
the
gh43883-gcs-testbench-py-version
branch
from
d8cd7cf
to
0f522cd
Compare
|
@github-actions crossbow submit wheel-macos-big-sur-cp38-arm64 wheel-macos-big-sur-cp313-arm64 wheel-macos-catalina-cp38-amd64 wheel-macos-catalina-cp313-amd64 |
This comment was marked as outdated.
This comment was marked as outdated.
pitrou
force-pushed
the
gh43883-gcs-testbench-py-version
branch
from
0f522cd
to
ea00794
Compare
|
@github-actions crossbow submit wheel-macos wheel-linux |
|
@github-actions crossbow submit -g cpp -g python -g r |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
pitrou
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
github-actions
bot
added
awaiting merge
pitrou
force-pushed
the
gh43883-gcs-testbench-py-version
branch
from
ea00794
to
9118ef1
Compare
|
@github-actions crossbow submit -g cpp -g python |
|
@github-actions crossbow submit wheelmacos wheellinux |
|
Revision: 9118ef1 Submitted crossbow builds: ursacomputing/crossbow @ actions-a6eb850120
|
|
Revision: 9118ef1 Submitted crossbow builds: ursacomputing/crossbow @ actions-b4e876b95b
|
|
I've addressed your review comments @kou (I didn't know bash had arrays!). I'll merge if CI passes. Thank you! |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7d4cf37. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
mapleFU
pushed a commit
to mapleFU/arrow
that referenced
this pull request
Sep 3, 2024
…testbench (apache#43884) We can now use the GCS testbench even if we are testing a Python version that does not support it. * GitHub Issue: apache#43883 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Sep 6, 2024
…testbench (apache#43884) We can now use the GCS testbench even if we are testing a Python version that does not support it. * GitHub Issue: apache#43883 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
khwilson
pushed a commit
to khwilson/arrow
that referenced
this pull request
Sep 14, 2024
…testbench (apache#43884) We can now use the GCS testbench even if we are testing a Python version that does not support it. * GitHub Issue: apache#43883 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now use the GCS testbench even if we are testing a Python version that does not support it.