-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43883: [CI] Remove Python version guard when installing GCS testbench #43884
Conversation
|
@github-actions crossbow submit wheel-manylinux-2014-cp38-amd64 wheel-manylinux-2014-cp38-arm64 wheel-manylinux-2014-cp313-amd64 wheel-manylinux-2014-cp313-arm64 wheel-macos-big-sur-cp38-arm64 wheel-macos-big-sur-cp313-arm64 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
8fc4c1d
to
d8cd7cf
Compare
@github-actions crossbow submit wheel-macos-big-sur-cp38-arm64 wheel-macos-big-sur-cp313-arm64 wheel-macos-catalina-cp38-amd64 wheel-macos-catalina-cp313-amd64 |
This comment was marked as outdated.
This comment was marked as outdated.
d8cd7cf
to
0f522cd
Compare
@github-actions crossbow submit wheel-macos-big-sur-cp38-arm64 wheel-macos-big-sur-cp313-arm64 wheel-macos-catalina-cp38-amd64 wheel-macos-catalina-cp313-amd64 |
This comment was marked as outdated.
This comment was marked as outdated.
0f522cd
to
ea00794
Compare
@github-actions crossbow submit wheel-macos wheel-linux |
@github-actions crossbow submit -g cpp -g python -g r |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
ea00794
to
9118ef1
Compare
@github-actions crossbow submit -g cpp -g python |
@github-actions crossbow submit wheelmacos wheellinux |
Revision: 9118ef1 Submitted crossbow builds: ursacomputing/crossbow @ actions-a6eb850120 |
Revision: 9118ef1 Submitted crossbow builds: ursacomputing/crossbow @ actions-b4e876b95b |
I've addressed your review comments @kou (I didn't know bash had arrays!). I'll merge if CI passes. Thank you! |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7d4cf37. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…testbench (apache#43884) We can now use the GCS testbench even if we are testing a Python version that does not support it. * GitHub Issue: apache#43883 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
…testbench (apache#43884) We can now use the GCS testbench even if we are testing a Python version that does not support it. * GitHub Issue: apache#43883 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
…testbench (apache#43884) We can now use the GCS testbench even if we are testing a Python version that does not support it. * GitHub Issue: apache#43883 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
We can now use the GCS testbench even if we are testing a Python version that does not support it.