Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-43118: [JS] Add interval for unit MONTH_DAY_NANO #43117

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

GH-43118: [JS] Add interval for unit MONTH_DAY_NANO #43117

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c2d5f55
[JS]: Add interval for unit MONTH_DAY_NANO
handstuyennn Jul 2, 2024
9f2c015
[CI][JS] Update code formatting
handstuyennn Jul 3, 2024
be61e7e
[CI][JS] Update semicolon
handstuyennn Jul 3, 2024
09337f2
[JS]: Remove skip js test and update ci test
handstuyennn Jul 4, 2024
159c4fc
[JS]: Update integration tests for interval
handstuyennn Sep 4, 2024
1b4d1be
[JS]: Format Python code
handstuyennn Sep 4, 2024
ade6c83
[JS]: Skip js integration tests for interval
handstuyennn Sep 4, 2024
88ffddb
[JS] Add utility functions for encoding interval data from JSON IPC data
hangxingliu Sep 27, 2024
c51a503
[JS] Restore js integration tests for interval
hangxingliu Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions dev/archery/archery/integration/datagen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,13 +412,9 @@ def _get_type(self):

def generate_column(self, size, name=None):
min_day_value, max_day_value = -10000*366, 10000*366
# values = [{'days': random.randint(min_day_value, max_day_value),
# 'milliseconds': random.randint(-86400000, +86400000)}
# for _ in range(size)]
values = []
for _ in range(size):
values.append(random.randint(min_day_value, max_day_value))
values.append(random.randint(-86400000, +86400000))
values = [{'days': random.randint(min_day_value, max_day_value),
'milliseconds': random.randint(-86400000, +86400000)}
for _ in range(size)]

is_valid = self._make_is_valid(size)
if name is None:
Expand Down Expand Up @@ -1891,9 +1887,11 @@ def _temp_path():

generate_duration_case(),

generate_interval_case(),
generate_interval_case()
.skip_tester('JS'),

generate_month_day_nano_interval_case(),
generate_month_day_nano_interval_case()
.skip_tester('JS'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why skip this test? Isn't this the point of this pull request?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @domoritz The issues about interval data in JSON format just been fixed in the latest commit. Please check it. Thank you


generate_map_case(),

Expand Down
Loading