-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41735: [CI][Archery] Update archery to be compatible with pygit2 1.15 API change #41739
Conversation
…git2 1.15 API change
|
@github-actions crossbow submit -g python |
|
This will fail until it is merged on main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Let's try this!
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 11decbc. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…git2 1.15 API change (apache#41739) ### Rationale for this change pygit2 updated how they expose some of the `GIT_OBJ` variables to use `GIT_OBJECT` prefix here: libgit2/pygit2@8b3861b ### What changes are included in this PR? Update code to make it compatible with both possible APIs. ### Are these changes tested? Via archery ### Are there any user-facing changes? No * GitHub Issue: apache#41735 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…git2 1.15 API change (apache#41739) ### Rationale for this change pygit2 updated how they expose some of the `GIT_OBJ` variables to use `GIT_OBJECT` prefix here: libgit2/pygit2@8b3861b ### What changes are included in this PR? Update code to make it compatible with both possible APIs. ### Are these changes tested? Via archery ### Are there any user-facing changes? No * GitHub Issue: apache#41735 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…git2 1.15 API change (apache#41739) ### Rationale for this change pygit2 updated how they expose some of the `GIT_OBJ` variables to use `GIT_OBJECT` prefix here: libgit2/pygit2@8b3861b ### What changes are included in this PR? Update code to make it compatible with both possible APIs. ### Are these changes tested? Via archery ### Are there any user-facing changes? No * GitHub Issue: apache#41735 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
pygit2 updated how they expose some of the
GIT_OBJ
variables to useGIT_OBJECT
prefix here: libgit2/pygit2@8b3861bWhat changes are included in this PR?
Update code to make it compatible with both possible APIs.
Are these changes tested?
Via archery
Are there any user-facing changes?
No