GH-41562: [C++][Parquet] Decoding: Fix num_value handling in ByteStreamSplitDecoder #41565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pitrou
reviewed
May 7, 2024
github-actions
bot
added
awaiting committer review
pitrou
reviewed
May 7, 2024
mapleFU
force-pushed
the
fix-byte-stream-split-problem
branch
from
b51608a to
ddd0cde
Compare
pitrou
reviewed
May 7, 2024
cpp/src/parquet/encoding.h
Outdated
Comment on lines
259
to
261
| // In current implementations, `num_values` is the `num_values` field in the | ||
| // data page header, which may greater than the number of values in the data | ||
| // buffer. |
There was a problem hiding this comment.
Suggested change
| // In current implementations, `num_values` is the `num_values` field in the | |
| // data page header, which may greater than the number of values in the data | |
| // buffer. | |
| // `num_values` comes from the data page header, and may be greater than the number of | |
| // physical values in the data buffer if there are some omitted (null) values. | |
| // `len`, on the other hand, is the size in bytes of the data buffer and | |
| // directly relates to the number of physical values. |
|
@github-actions crossbow submit -g cpp |
|
Revision: 7daee1c Submitted crossbow builds: ursacomputing/crossbow @ actions-655ed96d55
|
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 9cf0ee7. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them. |
raulcd
pushed a commit
that referenced
this pull request
May 8, 2024
…amSplitDecoder (#41565) ### Rationale for this change This problem is raised from #40094 . Original bug fixed here: #34140 , but this is corrupt in #40094 . ### What changes are included in this PR? Refine checking ### Are these changes tested? * [x] Will add ### Are there any user-facing changes? Bugfix * GitHub Issue: #41562 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…teStreamSplitDecoder (apache#41565) ### Rationale for this change This problem is raised from apache#40094 . Original bug fixed here: apache#34140 , but this is corrupt in apache#40094 . ### What changes are included in this PR? Refine checking ### Are these changes tested? * [x] Will add ### Are there any user-facing changes? Bugfix * GitHub Issue: apache#41562 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This problem is raised from #40094 . Original bug fixed here: #34140 , but this is corrupt in #40094 .
What changes are included in this PR?
Refine checking
Are these changes tested?
Are there any user-facing changes?
Bugfix