-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41375: [C#] Move to .NET 8.0 #41376
Conversation
I think all the failing checks are due to the recent macos-latest change, but am not confident that it's the case. |
) ### Rationale for this change Ruby 2.7 doesn't exist on `macos-latest` (`macos-14`). ### What changes are included in this PR? Use `ruby` as the Ruby version to use the latest Ruby. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#41371 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@github-actions crossbow submit nuget |
@github-actions crossbow submit csharp |
Revision: 1439115 Submitted crossbow builds: ursacomputing/crossbow @ actions-a0ad3baf29
|
Revision: 1439115 Submitted crossbow builds: ursacomputing/crossbow @ actions-4f3461e690 |
Change looks good to me. There is a single error on CI around the .NET jobs but I think is unrelated:
@kou @assignUser is this something you've seen somewhere else? |
We need to use venv as the message said or actions/setup-python. |
I've opened #41390 to follow the error |
Yeah, this is a recent change in the brew python. As kou said using venv solves it. |
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 2710626. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### What changes are included in this PR? Changes to workflow infrastructure and projects to install and target net8.0 instead of net7.0. ### Are these changes tested? Yes ### Are there any user-facing changes? Users will need to install .NET 8 to run tests and examples. No impact on product code. Closes apache#41375 * GitHub Issue: apache#41375 Lead-authored-by: Curt Hagenlocher <curt@hagenlocher.org> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
### What changes are included in this PR? Changes to workflow infrastructure and projects to install and target net8.0 instead of net7.0. ### Are these changes tested? Yes ### Are there any user-facing changes? Users will need to install .NET 8 to run tests and examples. No impact on product code. Closes apache#41375 * GitHub Issue: apache#41375 Lead-authored-by: Curt Hagenlocher <curt@hagenlocher.org> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
### What changes are included in this PR? Changes to workflow infrastructure and projects to install and target net8.0 instead of net7.0. ### Are these changes tested? Yes ### Are there any user-facing changes? Users will need to install .NET 8 to run tests and examples. No impact on product code. Closes apache#41375 * GitHub Issue: apache#41375 Lead-authored-by: Curt Hagenlocher <curt@hagenlocher.org> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
What changes are included in this PR?
Changes to workflow infrastructure and projects to install and target net8.0 instead of net7.0.
Are these changes tested?
Yes
Are there any user-facing changes?
Users will need to install .NET 8 to run tests and examples. No impact on product code.
Closes #41375