Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41375: [C#] Move to .NET 8.0 #41376

Merged
merged 7 commits into from
Apr 26, 2024
Merged

Conversation

CurtHagenlocher
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher commented Apr 25, 2024

What changes are included in this PR?

Changes to workflow infrastructure and projects to install and target net8.0 instead of net7.0.

Are these changes tested?

Yes

Are there any user-facing changes?

Users will need to install .NET 8 to run tests and examples. No impact on product code.

Closes #41375

@CurtHagenlocher
Copy link
Contributor Author

I think all the failing checks are due to the recent macos-latest change, but am not confident that it's the case.

kou and others added 5 commits April 25, 2024 18:24
)

### Rationale for this change

Ruby 2.7 doesn't exist on `macos-latest` (`macos-14`).

### What changes are included in this PR?

Use `ruby` as the Ruby version to use the latest Ruby.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41371

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@raulcd
Copy link
Member

raulcd commented Apr 26, 2024

@github-actions crossbow submit nuget

@raulcd
Copy link
Member

raulcd commented Apr 26, 2024

@github-actions crossbow submit csharp

Copy link

Revision: 1439115

Submitted crossbow builds: ursacomputing/crossbow @ actions-a0ad3baf29

Task Status
nuget GitHub Actions

Copy link

Revision: 1439115

Submitted crossbow builds: ursacomputing/crossbow @ actions-4f3461e690

Task Status
verify-rc-source-csharp-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-csharp-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-csharp-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-csharp-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-csharp-macos-amd64 GitHub Actions
verify-rc-source-csharp-macos-arm64 GitHub Actions

@raulcd
Copy link
Member

raulcd commented Apr 26, 2024

Change looks good to me. There is a single error on CI around the .NET jobs but I think is unrelated:
https://github.com/apache/arrow/actions/runs/8836761043/job/24264073837?pr=41376

Run ci/scripts/csharp_test.sh $(pwd)
+ source_dir=/Users/runner/work/arrow/arrow/csharp
+ '[' -z '' ']'
+ type python3
+ export PYTHON=python3
+ PYTHON=python3
+ python3 -m pip install pyarrow find-libpython
error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try brew install
    xyz, where xyz is the package you are trying to
    install.
    
    If you wish to install a Python library that isn't in Homebrew,
    use a virtual environment:
    
    python3 -m venv path/to/venv
    source path/to/venv/bin/activate
    python3 -m pip install xyz
    
    If you wish to install a Python application that isn't in Homebrew,
    it may be easiest to use 'pipx install xyz', which will manage a
    virtual environment for you. You can install pipx with
    
    brew install pipx
    
    You may restore the old behavior of pip by passing
    the '--break-system-packages' flag to pip, or by adding
    'break-system-packages = true' to your pip.conf file. The latter
    will permanently disable this error.
    
    If you disable this error, we STRONGLY recommend that you additionally
    pass the '--user' flag to pip, or set 'user = true' in your pip.conf
    file. Failure to do this can result in a broken Homebrew installation.
    
    Read more about this behavior here: <https://peps.python.org/pep-0668/>

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP 668 for the detailed specification.

@kou @assignUser is this something you've seen somewhere else?
I am happy to merge this PR as it seems related to the macOS changes for GitHub runners.

@kou
Copy link
Member

kou commented Apr 26, 2024

We need to use venv as the message said or actions/setup-python.

@raulcd
Copy link
Member

raulcd commented Apr 26, 2024

I've opened #41390 to follow the error

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Apr 26, 2024
@assignUser
Copy link
Member

Yeah, this is a recent change in the brew python. As kou said using venv solves it.

@CurtHagenlocher CurtHagenlocher merged commit 2710626 into apache:main Apr 26, 2024
53 of 57 checks passed
@CurtHagenlocher CurtHagenlocher removed the awaiting merge Awaiting merge label Apr 26, 2024
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 2710626.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

tolleybot pushed a commit to tmct/arrow that referenced this pull request May 2, 2024
### What changes are included in this PR?

Changes to workflow infrastructure and projects to install and target net8.0 instead of net7.0.

### Are these changes tested?

Yes

### Are there any user-facing changes?

Users will need to install .NET 8 to run tests and examples. No impact on product code.

Closes apache#41375
* GitHub Issue: apache#41375

Lead-authored-by: Curt Hagenlocher <curt@hagenlocher.org>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
### What changes are included in this PR?

Changes to workflow infrastructure and projects to install and target net8.0 instead of net7.0.

### Are these changes tested?

Yes

### Are there any user-facing changes?

Users will need to install .NET 8 to run tests and examples. No impact on product code.

Closes apache#41375
* GitHub Issue: apache#41375

Lead-authored-by: Curt Hagenlocher <curt@hagenlocher.org>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
@CurtHagenlocher CurtHagenlocher deleted the GH-41375 branch June 14, 2024 02:21
CurtHagenlocher added a commit to CurtHagenlocher/arrow that referenced this pull request Jun 14, 2024
### What changes are included in this PR?

Changes to workflow infrastructure and projects to install and target net8.0 instead of net7.0.

### Are these changes tested?

Yes

### Are there any user-facing changes?

Users will need to install .NET 8 to run tests and examples. No impact on product code.

Closes apache#41375
* GitHub Issue: apache#41375

Lead-authored-by: Curt Hagenlocher <curt@hagenlocher.org>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C#] Move to net8.0 for running tests in workflows
4 participants