MINOR: [C++][Parquet] fix dict_length for ReadDictionary when not having dict #41344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
mapleFU
changed the title
github-actions
bot
added
awaiting committer review
mapleFU
changed the title
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 774f10d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 13 possible false positives for unstable benchmarks that are known to sometimes produce them. |
tolleybot
pushed a commit
to tmct/arrow
that referenced
this pull request
May 2, 2024
…ing dict (apache#41344) ### Rationale for this change `dictionary_length = 0` is used when page doesn't have dictionary, however, this should be a nop. ### What changes are included in this PR? Change `dictionary_length = 0` to `*dictionary_length = 0`. ### Are these changes tested? No? ### Are there any user-facing changes? no Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: mwish <maplewish117@gmail.com>
|
It would have been nice to add a test for this. |
|
Sigh, seems even the author doesn't reply that, I think that doesn't have user, and maybe before Read, the value would be 0 :-( |
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…ing dict (apache#41344) ### Rationale for this change `dictionary_length = 0` is used when page doesn't have dictionary, however, this should be a nop. ### What changes are included in this PR? Change `dictionary_length = 0` to `*dictionary_length = 0`. ### Are these changes tested? No? ### Are there any user-facing changes? no Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: mwish <maplewish117@gmail.com>
CurtHagenlocher
pushed a commit
to CurtHagenlocher/arrow
that referenced
this pull request
Jun 14, 2024
…ing dict (apache#41344) ### Rationale for this change `dictionary_length = 0` is used when page doesn't have dictionary, however, this should be a nop. ### What changes are included in this PR? Change `dictionary_length = 0` to `*dictionary_length = 0`. ### Are these changes tested? No? ### Are there any user-facing changes? no Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: mwish <maplewish117@gmail.com>
|
sorry for the late reply, thanks for catching this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
dictionary_length = 0is used when page doesn't have dictionary, however, this should be a nop.What changes are included in this PR?
Change
dictionary_length = 0to*dictionary_length = 0.Are these changes tested?
No?
Are there any user-facing changes?
no