Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-40602: [C++] Move mold linker flags to variables #40603

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

cryos
Copy link
Contributor

@cryos cryos commented Mar 16, 2024

Rationale for this change

Move the mold linker flags to the CMake CMAKE_*_LINKER_FLAGS variables. This is the more correct place to add them as they will only be used during linking, it would invalidate any [s]ccache less frequently if changing linkers and I think it is more clear/correct.

What changes are included in this PR?

Moving the mold linker flags from the CMAKE_*_FLAGS to CMAKE_*_LINKER_FLAGS.

Are these changes tested?

Existing tests and validation would cover these changes and the result is essentially the same as before.

Are there any user-facing changes?

No

Move the mold linker flags to the CMake CMAKE_*_LINKER_FLAGS variables.
Copy link

⚠️ GitHub issue #40602 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Thanks. I couldn't remember these flags when I wrote this feature.

cpp/cmake_modules/SetupCxxFlags.cmake Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Mar 18, 2024
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@cryos
Copy link
Contributor Author

cryos commented Mar 18, 2024

Thanks, I need to use string(APPEND ...) more, I had forgotten that had been added and love removing repetition!

@kou kou merged commit bb9f229 into apache:main Mar 19, 2024
33 checks passed
@kou kou removed the awaiting merge Awaiting merge label Mar 19, 2024
@kou
Copy link
Member

kou commented Mar 19, 2024

Merged.

BTW, do you want to work on related issue #40400 ?

@cryos
Copy link
Contributor Author

cryos commented Mar 19, 2024

Merged.

BTW, do you want to work on related issue #40400 ?

I could help with that, thanks @kou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants