GH-40153: [Python] Avoid using np.take in Array.to_numpy() #40295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@github-actions crossbow submit -g python |
|
Revision: 7fc1ec7 Submitted crossbow builds: ursacomputing/crossbow @ actions-a31e58e0d0
|
jorisvandenbossche
approved these changes
Feb 29, 2024
| @@ -2515,6 +2515,8 @@ Status ConvertChunkedArrayToPandas(const PandasOptions& options, | |||
| std::shared_ptr<ChunkedArray> arr, PyObject* py_ref, | |||
| PyObject** out) { | |||
| if (options.decode_dictionaries && arr->type()->id() == Type::DICTIONARY) { | |||
| // XXX we should return an error as below if options.zero_copy_only | |||
| // is true, but that would break compatibility with existing tests. | |||
There was a problem hiding this comment.
At the moment we essentially just ignore the zero_copy_only keyword in case of a DictionaryArray?
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 5c4869d. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
…che#40295) ### Rationale for this change `Array.to_numpy` calls `np.take` to linearize dictionary arrays. This fails on 32-bit Numpy builds because we give Numpy 64-bit indices and Numpy would like to downcast them. ### What changes are included in this PR? Avoid calling `np.take`, instead using our own dictionary decoding routine. ### Are these changes tested? Yes. A test failure is fixed on 32-bit. ### Are there any user-facing changes? No. * GitHub Issue: apache#40153 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Array.to_numpycallsnp.taketo linearize dictionary arrays. This fails on 32-bit Numpy builds because we give Numpy 64-bit indices and Numpy would like to downcast them.What changes are included in this PR?
Avoid calling
np.take, instead using our own dictionary decoding routine.Are these changes tested?
Yes. A test failure is fixed on 32-bit.
Are there any user-facing changes?
No.