Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-40004: [Python][FlightRPC] Release GIL in GeneratorStream #40005

Merged
merged 1 commit into from
Feb 8, 2024
Merged

GH-40004: [Python][FlightRPC] Release GIL in GeneratorStream #40005

merged 1 commit into from
Feb 8, 2024

Conversation

lupko
Copy link
Contributor

@lupko lupko commented Feb 8, 2024 •
edited by github-actions bot
Loading

@lupko lupko requested a review from lidavidm as a code owner February 8, 2024 19:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024

⚠️ GitHub issue #40004 has been automatically assigned in GitHub to PR creator.

lidavidm
lidavidm approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Feb 8, 2024
@lidavidm lidavidm merged commit 8f15374 into apache:main Feb 8, 2024
11 of 12 checks passed
@lidavidm lidavidm removed the awaiting merge Awaiting merge label Feb 8, 2024
@conbench-apache-arrow conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 8f15374.

There were 2 benchmark results indicating a performance regression:

The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@lupko @dgreiss
apacheGH-40004: [Python][FlightRPC] Release GIL in GeneratorStream (a…
b43da57 
…pache#40005)

Fixes apache#40004.

* Closes: apache#40004

Authored-by: lupko <lubomir.slivka@gooddata.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
raulcd pushed a commit that referenced this pull request Feb 20, 2024
@lupko @raulcd
GH-40004: [Python][FlightRPC] Release GIL in GeneratorStream (#40005)
4b11536 
Fixes #40004.

* Closes: #40004

Authored-by: lupko <lubomir.slivka@gooddata.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Feb 28, 2024
@lupko @zanmato1984
apacheGH-40004: [Python][FlightRPC] Release GIL in GeneratorStream (a…
3fda771 
…pache#40005)

Fixes apache#40004.

* Closes: apache#40004

Authored-by: lupko <lubomir.slivka@gooddata.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Mar 8, 2024
@lupko @thisisnic
apacheGH-40004: [Python][FlightRPC] Release GIL in GeneratorStream (a…
999b190 
…pache#40005)

Fixes apache#40004.

* Closes: apache#40004

Authored-by: lupko <lubomir.slivka@gooddata.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees
No one assigned
Labels
Component: FlightRPC Component: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Python][FlightRPC] Interpreter deadlock when using GeneratorStream and Acero + Python UDFs
2 participants
@lupko @lidavidm