-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-39779: [Python] Expose force_virtual_addressing in PyArrow #39819
Conversation
|
Thank you for you contribution @yo1956 ! From a quick look I think that the Cython layer will have to be updated to include the arrow/python/pyarrow/includes/libarrow_fs.pxd Lines 161 to 185 in 21ffd82
|
@AlenkaF |
@AlenkaF |
The failures are not related, there is a fix already open: #39827. Similar for the Sphinx build. We can wait for them to get merged and rebase then. |
5734aa3
to
d027bb8
Compare
d027bb8
to
4754614
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the updates!
I do not think there are any additions needed in the tests, but would like to have one extra approve before merging.
@AlenkaF |
@jorisvandenbossche |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 3d45ac9. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…pache#39819) ### Rationale for this change / What changes are included in this PR? To expose force_virtual_addressing in PyArrow. ### Are these changes tested? Existing unit tests are not broken, and a new test case have been added. ### Are there any user-facing changes? pyarrow.fs.S3FileSystem: it becomes possible to specify the argument 'force_virtual_addressing'. * Closes: apache#39779 Authored-by: yo1956 <hm.hr.yossy@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
…pache#39819) ### Rationale for this change / What changes are included in this PR? To expose force_virtual_addressing in PyArrow. ### Are these changes tested? Existing unit tests are not broken, and a new test case have been added. ### Are there any user-facing changes? pyarrow.fs.S3FileSystem: it becomes possible to specify the argument 'force_virtual_addressing'. * Closes: apache#39779 Authored-by: yo1956 <hm.hr.yossy@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
…pache#39819) ### Rationale for this change / What changes are included in this PR? To expose force_virtual_addressing in PyArrow. ### Are these changes tested? Existing unit tests are not broken, and a new test case have been added. ### Are there any user-facing changes? pyarrow.fs.S3FileSystem: it becomes possible to specify the argument 'force_virtual_addressing'. * Closes: apache#39779 Authored-by: yo1956 <hm.hr.yossy@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Rationale for this change / What changes are included in this PR?
To expose force_virtual_addressing in PyArrow.
Are these changes tested?
Existing unit tests are not broken, and a new test case have been added.
Are there any user-facing changes?
pyarrow.fs.S3FileSystem: it becomes possible to specify the argument 'force_virtual_addressing'.