Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-39779: [Python] Expose force_virtual_addressing in PyArrow #39819

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

teihenn
Copy link
Contributor

@teihenn teihenn commented Jan 27, 2024

Rationale for this change / What changes are included in this PR?

To expose force_virtual_addressing in PyArrow.

Are these changes tested?

Existing unit tests are not broken, and a new test case have been added.

Are there any user-facing changes?

pyarrow.fs.S3FileSystem: it becomes possible to specify the argument 'force_virtual_addressing'.

Copy link

⚠️ GitHub issue #39779 has been automatically assigned in GitHub to PR creator.

@AlenkaF
Copy link
Member

AlenkaF commented Jan 29, 2024

Thank you for you contribution @yo1956 !

From a quick look I think that the Cython layer will have to be updated to include the force_virtual_addressing

cdef cppclass CS3Options "arrow::fs::S3Options":
c_string region
double connect_timeout
double request_timeout
c_string endpoint_override
c_string scheme
c_bool background_writes
c_bool allow_bucket_creation
c_bool allow_bucket_deletion
shared_ptr[const CKeyValueMetadata] default_metadata
c_string role_arn
c_string session_name
c_string external_id
int load_frequency
CS3ProxyOptions proxy_options
CS3CredentialsKind credentials_kind
shared_ptr[CS3RetryStrategy] retry_strategy
void ConfigureDefaultCredentials()
void ConfigureAccessKey(const c_string& access_key,
const c_string& secret_key,
const c_string& session_token)
c_string GetAccessKey()
c_string GetSecretKey()
c_string GetSessionToken()
c_bool Equals(const CS3Options& other)

@teihenn
Copy link
Contributor Author

teihenn commented Jan 29, 2024

@AlenkaF
Thank you for reviewing!
I'll fix it.

@teihenn
Copy link
Contributor Author

teihenn commented Jan 29, 2024

@AlenkaF
I've made the modifications, but it seems there are errors with CI that doesn't appear to be related to my changes.
I'm not entirely sure, though. I would be grateful if you could provide some advice when you have time.

@AlenkaF
Copy link
Member

AlenkaF commented Jan 29, 2024

The failures are not related, there is a fix already open: #39827. Similar for the Sphinx build.

We can wait for them to get merged and rebase then.

Copy link
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the updates!

I do not think there are any additions needed in the tests, but would like to have one extra approve before merging.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jan 30, 2024
@teihenn
Copy link
Contributor Author

teihenn commented Jan 30, 2024

LGTM, thank you for the updates!

I do not think there are any additions needed in the tests, but would like to have one extra approve before merging.

@AlenkaF
Thank you!!

@teihenn
Copy link
Contributor Author

teihenn commented Feb 1, 2024

@jorisvandenbossche
Could you please review this when you have time?

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jorisvandenbossche jorisvandenbossche merged commit 3d45ac9 into apache:main Feb 1, 2024
13 checks passed
@jorisvandenbossche jorisvandenbossche removed the awaiting committer review Awaiting committer review label Feb 1, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Feb 1, 2024
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 3d45ac9.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…pache#39819)

### Rationale for this change / What changes are included in this PR?

To expose force_virtual_addressing in PyArrow.

### Are these changes tested?

Existing unit tests are not broken, and a new test case have been added.

### Are there any user-facing changes?

pyarrow.fs.S3FileSystem: it becomes possible to specify the argument 'force_virtual_addressing'.

* Closes: apache#39779

Authored-by: yo1956 <hm.hr.yossy@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Feb 28, 2024
…pache#39819)

### Rationale for this change / What changes are included in this PR?

To expose force_virtual_addressing in PyArrow.

### Are these changes tested?

Existing unit tests are not broken, and a new test case have been added.

### Are there any user-facing changes?

pyarrow.fs.S3FileSystem: it becomes possible to specify the argument 'force_virtual_addressing'.

* Closes: apache#39779

Authored-by: yo1956 <hm.hr.yossy@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Mar 8, 2024
…pache#39819)

### Rationale for this change / What changes are included in this PR?

To expose force_virtual_addressing in PyArrow.

### Are these changes tested?

Existing unit tests are not broken, and a new test case have been added.

### Are there any user-facing changes?

pyarrow.fs.S3FileSystem: it becomes possible to specify the argument 'force_virtual_addressing'.

* Closes: apache#39779

Authored-by: yo1956 <hm.hr.yossy@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python] Expose force_virtual_addressing in PyArrow
3 participants