GH-38865 [C++][Parquet] support passing a RowRange to RecordBatchReader #39731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
one thread for each logical range fix prebuffer conflict with datappagefilter fix coalesce problem ading tests fix style
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR is a supserset of #39608.
Skipping Page IO is supported in Pre-Buffer read mode.
What changes are included in this PR?
In this PR, RangeCacheEntry cached in range cache is modified:
Instead of caching the whole ReadRange, we excluded the bytes within
holes, which is calculated by user specified RowRange.Are these changes tested?
Yes, range_read_test.cc
Are there any user-facing changes?
a new GetRecordBatchReader API overload is added. NO existing API is broken