GH-39722: [JS] Clean up packaging #39723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
domoritz
commented
Jan 21, 2024
•
domoritz
commented
- Remove .mts since it's the same as .ts
- Use .js consistently for all packages
- Closes: [JS] Clean up packaging #39722
github-actions
bot
added
Component: JavaScript
awaiting committer review
domoritz
commented
Jan 21, 2024
| const cjsGlob = `${targetDir(`es2015`, `cjs`)}/**/*.js`; | ||
| const esmGlob = `${targetDir(`es2015`, `esm`)}/**/*.js`; | ||
| const es2015UmdGlob = `${targetDir(`es2015`, `umd`)}/*.js`; | ||
| const esnextUmdGlob = `${targetDir(`esnext`, `umd`)}/*.js`; | ||
| const cjsSourceMapsGlob = `${targetDir(`es2015`, `cjs`)}/**/*.map`; | ||
| const cjsSourceMapsGlob = `${targetDir(`es2015`, `cjs`)}/**/*.js.map`; |
There was a problem hiding this comment.
This is so we only copy the typescript typings source maps from esm
domoritz
changed the title
github-actions
bot
added
awaiting changes
domoritz
added
awaiting committer review
domoritz
requested review from
assignUser,
kou,
raulcd,
paleolimbot,
thisisnic,
lidavidm,
kevingurney,
zeroshade,
CurtHagenlocher,
wgtmac and
westonpace
as code owners
trxcllnt
removed request for
kou,
lidavidm,
zeroshade,
raulcd,
CurtHagenlocher,
westonpace and
wgtmac
…#41079) [//]: # (dependabot-start)⚠️ **Dependabot is rebasing this PR**⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.6.0 to 0.7.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golang/sync/commit/14be23e5b48bec28285f8a694875175ecacfddb3"><code>14be23e</code></a> semaphore: cancel acquisition with a done context</li> <li>See full diff in <a href="https://github.com/golang/sync/compare/v0.6.0...v0.7.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@ dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@ dependabot rebase` will rebase this PR - `@ dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@ dependabot merge` will merge this PR after your CI passes on it - `@ dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@ dependabot cancel merge` will cancel a previously requested merge and block automerging - `@ dependabot reopen` will reopen this PR if it is closed - `@ dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@ dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@ dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@ dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@ dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
|
Nice. I took it for a spin and source maps etc seem to work well even for the UMD bundles. Looks good. |
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit be5f5b8. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 13 possible false positives for unstable benchmarks that are known to sometimes produce them. |
tolleybot
pushed a commit
to tmct/arrow
that referenced
this pull request
May 2, 2024
* Remove .mts since it's the same as .ts * Use .js consistently for all packages * Closes: apache#39722 --------- Signed-off-by: Matt Topol <zotthewizard@gmail.com> Co-authored-by: ptaylor <paul.e.taylor@me.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
tolleybot
pushed a commit
to tmct/arrow
that referenced
this pull request
May 4, 2024
* Remove .mts since it's the same as .ts * Use .js consistently for all packages * Closes: apache#39722 --------- Signed-off-by: Matt Topol <zotthewizard@gmail.com> Co-authored-by: ptaylor <paul.e.taylor@me.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
rok
pushed a commit
to tmct/arrow
that referenced
this pull request
May 8, 2024
* Remove .mts since it's the same as .ts * Use .js consistently for all packages * Closes: apache#39722 --------- Signed-off-by: Matt Topol <zotthewizard@gmail.com> Co-authored-by: ptaylor <paul.e.taylor@me.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
rok
pushed a commit
to tmct/arrow
that referenced
this pull request
May 8, 2024
* Remove .mts since it's the same as .ts * Use .js consistently for all packages * Closes: apache#39722 --------- Signed-off-by: Matt Topol <zotthewizard@gmail.com> Co-authored-by: ptaylor <paul.e.taylor@me.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
* Remove .mts since it's the same as .ts * Use .js consistently for all packages * Closes: apache#39722 --------- Signed-off-by: Matt Topol <zotthewizard@gmail.com> Co-authored-by: ptaylor <paul.e.taylor@me.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.