-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-39126: [C++][CI] Fix Valgrind failures #39127
Conversation
|
@github-actions crossbow submit -g cpp |
@ursabot please benchmark |
Benchmark runs are scheduled for commit 196255c. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete. |
This comment was marked as outdated.
This comment was marked as outdated.
Thanks for your patience. Conbench analyzed the 6 benchmarking runs that have been run so far on PR commit 196255c. There were 22 benchmark results indicating a performance regression:
The full Conbench report has more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one nit:
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
@github-actions crossbow submit -g cpp |
Revision: 4bef4cc Submitted crossbow builds: ursacomputing/crossbow @ actions-235676da21 |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 31d2afc. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
### Rationale for this change ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#39126 Lead-authored-by: Antoine Pitrou <pitrou@free.fr> Co-authored-by: Antoine Pitrou <antoine@python.org> Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
### Rationale for this change ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#39126 Lead-authored-by: Antoine Pitrou <pitrou@free.fr> Co-authored-by: Antoine Pitrou <antoine@python.org> Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
### Rationale for this change ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#39126 Lead-authored-by: Antoine Pitrou <pitrou@free.fr> Co-authored-by: Antoine Pitrou <antoine@python.org> Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?