GH-39126: [C++][CI] Fix Valgrind failures #39127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@github-actions crossbow submit -g cpp |
|
@ursabot please benchmark |
|
Benchmark runs are scheduled for commit 196255c. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Thanks for your patience. Conbench analyzed the 6 benchmarking runs that have been run so far on PR commit 196255c. There were 22 benchmark results indicating a performance regression:
The full Conbench report has more details. |
github-actions
bot
added
awaiting changes
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
github-actions
bot
added
awaiting review
pitrou
commented
Dec 9, 2023
github-actions
bot
added
awaiting committer review
|
@github-actions crossbow submit -g cpp |
|
Revision: 4bef4cc Submitted crossbow builds: ursacomputing/crossbow @ actions-235676da21
|
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 31d2afc. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
mapleFU
pushed a commit
to mapleFU/arrow
that referenced
this pull request
Dec 13, 2023
### Rationale for this change ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#39126 Lead-authored-by: Antoine Pitrou <pitrou@free.fr> Co-authored-by: Antoine Pitrou <antoine@python.org> Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
clayburn
pushed a commit
to clayburn/arrow
that referenced
this pull request
Jan 23, 2024
### Rationale for this change ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#39126 Lead-authored-by: Antoine Pitrou <pitrou@free.fr> Co-authored-by: Antoine Pitrou <antoine@python.org> Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#39126 Lead-authored-by: Antoine Pitrou <pitrou@free.fr> Co-authored-by: Antoine Pitrou <antoine@python.org> Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?