GH-38906: [R] Improve Windows CI configuration #38927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
assignUser
reviewed
Nov 29, 2023
.github/workflows/r.yml
Outdated
| - name: Cache Docker Volumes | ||
| uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8 # v3.3.1 | ||
| with: | ||
| path: .docker | ||
| # As this key is identical on both matrix builds only one will be able to successfully cache, | ||
| # this is fine as there are no differences in the build | ||
| key: ubuntu-${{ matrix.ubuntu }}-r-${{ matrix.r }}-${{ hashFiles('cpp/src/**/*.cc','cpp/src/**/*.h)') }}-${{ github.run_id }} | ||
| restore-keys: | | ||
| ubuntu-${{ matrix.ubuntu }}-r-${{ matrix.r }}-${{ hashFiles('cpp/src/**/*.cc','cpp/src/**/*.h)') }}- | ||
| ubuntu-${{ matrix.ubuntu }}-r-${{ matrix.r }}- | ||
| - name: Setup Python |
assignUser
approved these changes
Nov 29, 2023
.github/workflows/r.yml
Outdated
| path: .docker | ||
| # As this key is identical on both matrix builds only one will be able to successfully cache, | ||
| # this is fine as there are no differences in the build | ||
| key: ubuntu-${{ matrix.ubuntu }}-r-${{ matrix.r }}-${{ hashFiles('cpp/src/**/*.cc','cpp/src/**/*.h)') }}-${{ github.run_id }} |
There was a problem hiding this comment.
the key doesn't work here as the values are not in the matrix, was this intentional?
There was a problem hiding this comment.
just saw the commit message^^ so this needs to be move up to it's intended place^^
There was a problem hiding this comment.
Ok, I think this is fixed!
github-actions
bot
added
awaiting changes
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 72d0969. There were 8 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change The Windows/R-devel job is causing CI to fail on many PRs that are unrelated to Windows/R-devel. We also have some outdated version numbers in the Windows action. ### What changes are included in this PR? The version for Windows was updated to "release", which should keep it current without explicit maintenance (since clearly we had forgotten to update the version numbers ourselves 😬 ). The devel version was removed because (1) it is failing and won't stop failing until an upstream PR to cpp11 is merged and (2) it's unclear to me that this check adds anything useful (we already test r-devel in another commit-level job). It may have dated from a time that r-devel on Windows was much different than r-release (it no longer is). ### Are these changes tested? Yes ### Are there any user-facing changes? No * Closes: apache#38906 Authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The Windows/R-devel job is causing CI to fail on many PRs that are unrelated to Windows/R-devel. We also have some outdated version numbers in the Windows action.
What changes are included in this PR?
The version for Windows was updated to "release", which should keep it current without explicit maintenance (since clearly we had forgotten to update the version numbers ourselves 😬 ). The devel version was removed because (1) it is failing and won't stop failing until an upstream PR to cpp11 is merged and (2) it's unclear to me that this check adds anything useful (we already test r-devel in another commit-level job). It may have dated from a time that r-devel on Windows was much different than r-release (it no longer is).
Are these changes tested?
Yes
Are there any user-facing changes?
No