Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-38900:[JS] Fix spelling #38901

Merged
merged 10 commits into from
Nov 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions js/src/enum.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// v4 doesn't seem to be able to tree-shake the rest of those exports.
//
// We will have to keep these enums in sync when we re-generate the flatbuffers
// code from the shchemas. See js/DEVELOP.md for info on how to run flatbuffers
// code from the schemas. See js/DEVELOP.md for info on how to run flatbuffers
// code generation.
//
////
Expand Down Expand Up @@ -174,7 +174,7 @@ export enum Type {
FixedSizeBinary = 15, /** Fixed-size binary. Each value occupies the same number of bytes */
FixedSizeList = 16, /** Fixed-size list. Each value occupies the same number of bytes */
Map = 17, /** Map of named logical types */
Duration = 18, /** Measure of elapsed time in either seconds, miliseconds, microseconds or nanoseconds. */
Duration = 18, /** Measure of elapsed time in either seconds, milliseconds, microseconds or nanoseconds. */

Dictionary = -1, /** Dictionary aka Category type */
Int8 = -2,
Expand Down Expand Up @@ -215,7 +215,7 @@ export enum BufferType {
OFFSET = 0,

/**
* actual data, either wixed width primitive types in slots or variable width delimited by an OFFSET vector
* actual data, either fixed width primitive types in slots or variable width delimited by an OFFSET vector
*/
DATA = 1,

Expand Down
2 changes: 1 addition & 1 deletion js/src/fb/timestamp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ import { TimeUnit } from './time-unit.js';
* no indication of how to map this information to a physical point in time.
* Naive date-times must be handled with care because of this missing
* information, and also because daylight saving time (DST) may make
* some values ambiguous or non-existent. A naive date-time may be
* some values ambiguous or nonexistent. A naive date-time may be
* stored as a struct with Date and Time fields. However, it may also be
* encoded into a Timestamp column with an empty timezone. The timestamp
* values should be computed "as if" the timezone of the date-time values
Expand Down
2 changes: 1 addition & 1 deletion js/src/ipc/reader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ export class RecordBatchReader<T extends TypeMap = any> extends ReadableInterop<

//
// Since TS is a structural type system, we define the following subclass stubs
// so that concrete types exist to associate with with the interfaces below.
// so that concrete types exist to associate with the interfaces below.
//
// The implementation for each RecordBatchReader is hidden away in the set of
// `RecordBatchReaderImpl` classes in the second half of this file. This allows
Expand Down
4 changes: 2 additions & 2 deletions js/src/vector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -302,8 +302,8 @@ export class Vector<T extends DataType = any> {
* values.
*
* Memoization is very useful when decoding a value is expensive such as
* Uft8. The memoization creates a cache of the size of the Vector and
* therfore increases memory usage.
* Utf8. The memoization creates a cache of the size of the Vector and
* therefore increases memory usage.
*
* @returns A new vector that memoizes calls to {@link get}.
*/
Expand Down
2 changes: 1 addition & 1 deletion js/src/visitor/builderctor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export class GetBuilderCtor extends Visitor {
public visitDurationSecond() { return DurationSecondBuilder; }
public visitDurationMillisecond() { return DurationMillisecondBuilder; }
public visitDurationMicrosecond() { return DurationMicrosecondBuilder; }
public visistDurationNanosecond() { return DurationNanosecondBuilder; }
public visitDurationNanosecond() { return DurationNanosecondBuilder; }
public visitFixedSizeList() { return FixedSizeListBuilder; }
public visitMap() { return MapBuilder; }
}
Expand Down
2 changes: 1 addition & 1 deletion js/src/visitor/indexof.ts
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ function indexOfValue<T extends DataType>(data: Data<T>, searchElement?: T['TVal
function indexOfUnion<T extends DataType>(data: Data<T>, searchElement?: T['TValue'] | null, fromIndex?: number): number {
// Unions are special -- they do have a nullBitmap, but so can their children.
// If the searchElement is null, we don't know whether it came from the Union's
// bitmap or one of its childrens'. So we don't interrogate the Union's bitmap,
// bitmap or one of its children's. So we don't interrogate the Union's bitmap,
// since that will report the wrong index if a child has a null before the Union.
const get = getVisitor.getVisitFn(data);
const compare = createElementComparator(searchElement);
Expand Down
4 changes: 2 additions & 2 deletions js/src/visitor/jsonvectorassembler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ export class JSONVectorAssembler extends Visitor {

/** @nocollapse */
public static assemble<T extends RecordBatch>(...batches: T[]) {
const assemlber = new JSONVectorAssembler();
const assembler = new JSONVectorAssembler();
return batches.map(({ schema, data }) => {
return assemlber.visitMany(schema.fields, data.children);
return assembler.visitMany(schema.fields, data.children);
});
}

Expand Down