-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-38893: [R] Fix printf syntax in altrep.cpp #38894
Conversation
|
The Windows error is from cpp11 (but also because we or somebody set
|
It looks like we are using most recent cpp11 and that doesn't show this issue on r devel, are we not vendoring the newest headers or something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix! I am going to merge this as the windows issue is not really related to this issue
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 9cece9d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change We have CI errors and CRAN check errors on R-devel, where the appropriate attribute for printf format checking was just added. ### What changes are included in this PR? The appopriate types are now used for printf parameters. ### Are these changes tested? Covered by existing tests ### Are there any user-facing changes? No * Closes: #38893 Authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
### Rationale for this change We have CI errors and CRAN check errors on R-devel, where the appropriate attribute for printf format checking was just added. ### What changes are included in this PR? The appopriate types are now used for printf parameters. ### Are these changes tested? Covered by existing tests ### Are there any user-facing changes? No * Closes: apache#38893 Authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
### Rationale for this change We have CI errors and CRAN check errors on R-devel, where the appropriate attribute for printf format checking was just added. ### What changes are included in this PR? The appopriate types are now used for printf parameters. ### Are these changes tested? Covered by existing tests ### Are there any user-facing changes? No * Closes: apache#38893 Authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Rationale for this change
We have CI errors and CRAN check errors on R-devel, where the appropriate attribute for printf format checking was just added.
What changes are included in this PR?
The appopriate types are now used for printf parameters.
Are these changes tested?
Covered by existing tests
Are there any user-facing changes?
No