-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-37803: [CI][Dev][Python] Release and merge script errors #37819
GH-37803: [CI][Dev][Python] Release and merge script errors #37819
Conversation
@github-actions crossbow submit test-conda-python-3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlenkaF is this still a draft? I am fine with merging this as is to fix the merge script + archery crossbow tasks, etcetera and maybe opening an issue to follow up to either fix it for setuptools_scm > 8.0.0 or change how we manage the version.
|
There are two files where I didn't pin |
@github-actions crossbow submit test-conda-python-3.10 |
|
Sorry you are correct, we have to pin it on archery too: https://github.com/apache/arrow/blob/main/dev/archery/setup.py#L33 |
@github-actions crossbow submit test-conda-python-3.10 |
|
I just validated we do the checkout from |
Got it. Let's give it a go 👍 |
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 79e49db. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
This might already be fixed in the meantime: pypa/setuptools-scm#919 (the same error message is mentioned on that issue, but didn't check if it actually fixed it) |
A permanent fix to make pyarrow build on latest setuptools + setuptools_scm would be highly desirable. I had to resort to the exact same version constraint myself in an emergency fix to unblock some automated build system failures. |
@cwegener I am not sure there is something to fix on our side. As far as I understand, it's a regression in setuptools_scm that will be fixed there (pypa/setuptools-scm#925, pypa/setuptools-scm#935). Ideally we would update old releases to add this upper pin for setuptools_scm in the meantime. But our release process is quite heavy, and hopefully a release of setuptools_scm fixing this issue will be released more quickly. Now, it seems that nowadays it is recommended to configure |
I opened a new issue about the problem of having to upper pin setuptools_scm right now with existing releases, so we have an open issue about this that users can find if they run into this -> #37931 And also opened an issue to track that we should move our setuptools_scm configuration to pyproject.toml -> #37929 |
…ache#37819) ### What changes are included in this PR? Pin the version of `setuptools_scm` to `<8.0.0`. * Closes: apache#37803 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Thanks so much for the detailed explanation! I was in a rush to fix the breakage and the huge amount of code in setup.py, plus the distractions of there also being a pyproject.toml that doesn't seem to be used yet was causing a lot of confusion for me. |
…ache#37819) ### What changes are included in this PR? Pin the version of `setuptools_scm` to `<8.0.0`. * Closes: apache#37803 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
…cation scripts (apache#37930) Follow-up on apache#37819, which missed one place to add a pin for the release verification scripts * Closes: apache#37803 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…cation scripts (apache#37930) Follow-up on apache#37819, which missed one place to add a pin for the release verification scripts * Closes: apache#37803 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…ache#37819) ### What changes are included in this PR? Pin the version of `setuptools_scm` to `<8.0.0`. * Closes: apache#37803 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
…cation scripts (apache#37930) Follow-up on apache#37819, which missed one place to add a pin for the release verification scripts * Closes: apache#37803 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…ache#37819) ### What changes are included in this PR? Pin the version of `setuptools_scm` to `<8.0.0`. * Closes: apache#37803 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
…cation scripts (apache#37930) Follow-up on apache#37819, which missed one place to add a pin for the release verification scripts * Closes: apache#37803 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…rors (apache#37819)" This reverts commit 79e49db.
…rge script errors (#37819)" (#40150) This reverts commit 79e49db. #37931 should have been fixed as of pypa/setuptools-scm@056584b in setuptools_scm 8.0.4; I tested that this works in conda-forge/arrow-cpp-feedstock#1314. CC @ AlenkaF @ raulcd * Closes: #37931 Authored-by: H. Vetinari <h.vetinari@gmx.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
…lease and merge script errors (apache#37819)" (apache#40150) This reverts commit 79e49db. apache#37931 should have been fixed as of pypa/setuptools-scm@056584b in setuptools_scm 8.0.4; I tested that this works in conda-forge/arrow-cpp-feedstock#1314. CC @ AlenkaF @ raulcd * Closes: apache#37931 Authored-by: H. Vetinari <h.vetinari@gmx.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
…lease and merge script errors (apache#37819)" (apache#40150) This reverts commit 79e49db. apache#37931 should have been fixed as of pypa/setuptools-scm@056584b in setuptools_scm 8.0.4; I tested that this works in conda-forge/arrow-cpp-feedstock#1314. CC @ AlenkaF @ raulcd * Closes: apache#37931 Authored-by: H. Vetinari <h.vetinari@gmx.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
What changes are included in this PR?
Pin the version of
setuptools_scm
to<8.0.0
.