-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-36927: [Java][Docs] Enable Gandiva build as part of Java maven commands #36929
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -984,13 +984,13 @@ | |
<properties> | ||
<arrow.dataset.jni.dist.dir>java-dist</arrow.dataset.jni.dist.dir> | ||
<cpp.dependencies.builded>false</cpp.dependencies.builded> | ||
<ARROW_CSV>ON</ARROW_CSV> | ||
<ARROW_DATASET>ON</ARROW_DATASET> | ||
<ARROW_GANDIVA>ON</ARROW_GANDIVA> | ||
<ARROW_ORC>ON</ARROW_ORC> | ||
<ARROW_PARQUET>ON</ARROW_PARQUET> | ||
<ARROW_GANDIVA>OFF</ARROW_GANDIVA> | ||
<ARROW_JAVA_JNI_ENABLE_C>OFF</ARROW_JAVA_JNI_ENABLE_C> | ||
<ARROW_JAVA_JNI_ENABLE_DATASET>ON</ARROW_JAVA_JNI_ENABLE_DATASET> | ||
<ARROW_JAVA_JNI_ENABLE_GANDIVA>OFF</ARROW_JAVA_JNI_ENABLE_GANDIVA> | ||
<ARROW_JAVA_JNI_ENABLE_GANDIVA>ON</ARROW_JAVA_JNI_ENABLE_GANDIVA> | ||
<ARROW_JAVA_JNI_ENABLE_ORC>ON</ARROW_JAVA_JNI_ENABLE_ORC> | ||
</properties> | ||
<build> | ||
|
@@ -1012,8 +1012,8 @@ | |
-S cpp | ||
-B cpp-jni | ||
-DARROW_BUILD_SHARED=OFF | ||
-DARROW_CSV=${ARROW_CSV} | ||
-DARROW_DATASET=ON | ||
-DARROW_CSV=${ARROW_DATASET} | ||
-DARROW_DATASET=${ARROW_DATASET} | ||
-DARROW_DEPENDENCY_SOURCE=BUNDLED | ||
-DARROW_DEPENDENCY_USE_SHARED=OFF | ||
-DARROW_FILESYSTEM=ON | ||
|
@@ -1070,6 +1070,8 @@ | |
-DCMAKE_INSTALL_LIBDIR=lib/${os.detected.arch} | ||
-DCMAKE_INSTALL_PREFIX=${arrow.dataset.jni.dist.dir} | ||
-DCMAKE_PREFIX_PATH=${project.basedir}/../java-dist/lib/${os.detected.arch}/cmake | ||
-DProtobuf_USE_STATIC_LIBS=ON | ||
-DProtobuf_ROOT=${project.basedir}/../cpp-jni/protobuf_ep-install | ||
</commandlineArgs> | ||
<workingDirectory>../</workingDirectory> | ||
</configuration> | ||
|
@@ -1099,13 +1101,14 @@ | |
<properties> | ||
<arrow.dataset.jni.dist.dir>java-dist</arrow.dataset.jni.dist.dir> | ||
<cpp.dependencies.builded>false</cpp.dependencies.builded> | ||
<ARROW_CSV>ON</ARROW_CSV> | ||
<ARROW_ORC>OFF</ARROW_ORC> | ||
<ARROW_DATASET>ON</ARROW_DATASET> | ||
<ARROW_GANDIVA>OFF</ARROW_GANDIVA> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think ARROW_GANDIVA is accidentally set to OFF here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Or is it not supported on Windows? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't have JNI yet because we need to install LLVM to build Gandiva (Could NOT find LLVM (missing: LLVM_DIR)). |
||
<ARROW_ORC>ON</ARROW_ORC> | ||
<ARROW_PARQUET>ON</ARROW_PARQUET> | ||
<ARROW_JAVA_JNI_ENABLE_C>OFF</ARROW_JAVA_JNI_ENABLE_C> | ||
<ARROW_JAVA_JNI_ENABLE_DATASET>ON</ARROW_JAVA_JNI_ENABLE_DATASET> | ||
<ARROW_JAVA_JNI_ENABLE_GANDIVA>OFF</ARROW_JAVA_JNI_ENABLE_GANDIVA> | ||
<ARROW_JAVA_JNI_ENABLE_ORC>OFF</ARROW_JAVA_JNI_ENABLE_ORC> | ||
<ARROW_JAVA_JNI_ENABLE_ORC>ON</ARROW_JAVA_JNI_ENABLE_ORC> | ||
</properties> | ||
<build> | ||
<plugins> | ||
|
@@ -1126,10 +1129,11 @@ | |
-S cpp | ||
-B cpp-jni | ||
-DARROW_BUILD_SHARED=OFF | ||
-DARROW_CSV=${ARROW_CSV} | ||
-DARROW_DATASET=ON | ||
-DARROW_CSV=${ARROW_DATASET} | ||
-DARROW_DATASET=${ARROW_DATASET} | ||
-DARROW_DEPENDENCY_USE_SHARED=OFF | ||
-DARROW_FILESYSTEM=ON | ||
-DARROW_GANDIVA=${ARROW_GANDIVA} | ||
-DARROW_JSON=${ARROW_DATASET} | ||
-DARROW_ORC=${ARROW_ORC} | ||
-DARROW_PARQUET=${ARROW_PARQUET} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity, why are we making this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, is this for https://github.com/apache/arrow/blob/main/java/gandiva/CMakeLists.txt#L41 ?
We can use this solution for now but we should find a better solution that doesn't require additional CMake options such as
Protobuf_ROOT
andProtobuf_USE_STATIC_LIBS
. Could you open an issue for it?(We may add support for installing bundled
protoc
for this case.)