GH-35404: [Docs] Fix logo url and temporarily pin sphinx to 5.x to #35405
Conversation
jorisvandenbossche
requested review from
assignUser,
kou and
raulcd
as code owners
|
|
|
@github-actions crossbow submit preview-docs |
|
Revision: 7f2d7b4 Submitted crossbow builds: ursacomputing/crossbow @ actions-f17fd805e0
|
|
@github-actions crossbow submit preview-docs |
|
Revision: 750b3cb Submitted crossbow builds: ursacomputing/crossbow @ actions-0a103adb20
|
jorisvandenbossche
changed the title
|
This seems to have worked: http://crossbow.voltrondata.com/pr_docs/35405/ |
kou
changed the title
| @@ -1,6 +1,6 @@ | |||
|
|
|||
| <a class="navbar-brand" href="{{ pathto(master_doc) }}"> | |||
| <img src="{{ pathto('_static/' + logo_url, 1) }}" class="logo" alt="logo"> | |||
| <img src="{{ logo_url|e }}" class="logo" alt="logo"> | |||
There was a problem hiding this comment.
Does this work only with Sphinx 5?
If this works with both of Sphinx 5 and 6, how about removing ,<6 for sphinx from this PR?
There was a problem hiding this comment.
This works for both but there are other issue (#35403) that require us to pin to <6 for now.
There was a problem hiding this comment.
Yes, @assignUser is spot on. This fixes the logo issue (#35406) regardless of the sphinx version, but we still need to fix the jquery dependency issue for being able to use sphinx 6
github-actions
bot
added
awaiting changes
|
Ah, thanks for catching this. I thought I tested the logo_url fix but maybe I didn't test with the same sphinx version 😦 |
|
Benchmark runs are scheduled for baseline = b9cc5df and contender = 57c956e. 57c956e is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
… to (apache#35405) See apache#35403 about requiring some fixes on our side to support sphinx 6. Until then, let's pin sphinx to <6. * Closes: apache#35404 * Closes: apache#35406 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
… to (apache#35405) See apache#35403 about requiring some fixes on our side to support sphinx 6. Until then, let's pin sphinx to <6. * Closes: apache#35404 * Closes: apache#35406 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
… to (apache#35405) See apache#35403 about requiring some fixes on our side to support sphinx 6. Until then, let's pin sphinx to <6. * Closes: apache#35404 * Closes: apache#35406 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
See #35403 about requiring some fixes on our side to support sphinx 6. Until then, let's pin sphinx to <6.