Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-4435: Minor fixups to csharp .sln and .csproj file #3529

Closed
wants to merge 2 commits into from
Closed

ARROW-4435: Minor fixups to csharp .sln and .csproj file #3529

wants to merge 2 commits into from

Conversation

eerhardt
Copy link
Contributor

  1. Add .sln file to the repo.
  2. Minor clean up of .csproj to move properties out of the Configuration/Platform PropertyGroups, which is the standard way of setting properties in SDK style projects.

@eerhardt
Minor fixups to csharp .sln and .csproj file
e9036b3 
1. Add .sln file to the repo.
2. Minor clean up of .csproj to move properties out of the Configuration/Platform PropertyGroups, which is the standard way of setting properties in SDK style projects.
@wesm
Copy link
Member

wesm commented Feb 1, 2019

Can you either add a license header or add this new file to the RAT exclusions list?

3.21s$ $TRAVIS_BUILD_DIR/ci/travis_release_audit.sh
NOT APPROVED: csharp/Apache.Arrow.sln (apache-arrow/csharp/Apache.Arrow.sln): false
1 unapproved licences. Check rat report: rat.txt
The command "$TRAVIS_BUILD_DIR/ci/travis_release_audit.sh" failed and exited with 1 during .

@eerhardt
Copy link
Contributor Author

eerhardt commented Feb 1, 2019

Can you either add a license header or add this new file to the RAT exclusions list?

I've added it to the RAT exclusions list, since .sln files can't have comments.

xhochy
xhochy approved these changes Feb 4, 2019
View reviewed changes
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@xhochy xhochy closed this in 07ab9cf Feb 4, 2019
@eerhardt eerhardt deleted the SolutionProjectFixUp branch February 4, 2019 18:04
xhochy pushed a commit that referenced this pull request Feb 8, 2019
@eerhardt @xhochy
ARROW-4435: Minor fixups to csharp .sln and .csproj file
1a9db10 
1. Add .sln file to the repo.
2. Minor clean up of .csproj to move properties out of the Configuration/Platform PropertyGroups, which is the standard way of setting properties in SDK style projects.

Author: Eric Erhardt <eric.erhardt@microsoft.com>

Closes #3529 from eerhardt/SolutionProjectFixUp and squashes the following commits:

88a7c6e <Eric Erhardt> Add RAT exclude for csharp sln file
e9036b3 <Eric Erhardt> Minor fixups to csharp .sln and .csproj file
@eerhardt eerhardt restored the SolutionProjectFixUp branch February 10, 2019 22:14
@eerhardt eerhardt deleted the SolutionProjectFixUp branch February 20, 2019 22:34
@rapoth rapoth mentioned this pull request Apr 24, 2019
Open
@asfimport asfimport mentioned this pull request Feb 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhochy xhochy xhochy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eerhardt @wesm @xhochy