Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-33854: [MATLAB] Add basic libmexclass integration code to MATLAB interface #34563

Merged
merged 57 commits into from
Apr 25, 2023
Merged

GH-33854: [MATLAB] Add basic libmexclass integration code to MATLAB interface #34563

merged 57 commits into from
Apr 25, 2023

Commits on Mar 8, 2023

  1. Add basic libmexclass integration code to MATLAB interface 

    CMakeLists.txt.

Co-authored-by: Sreehari Hegden <sreehari.hegden@gmail.com>
    @kevingurney @sreeharihegden
    kevingurney and sreeharihegden committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    c90fbd7 View commit details
    Browse the repository at this point in the history

  2. Set SOURCE_SUBDIR in the call to ExternalProject_Add to point to the … 

    …libmexclass CMakeLists.txt in the

libmexclass/cpp directory.

Co-authored-by: Sreehari Hegden <sreehari.hegden@gmail.com>
    @kevingurney @sreeharihegden
    kevingurney and sreeharihegden committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    5e0a794 View commit details
    Browse the repository at this point in the history

  3. Implement basic DoubleArrayProxy using libmexclass. 

    Co-authored-by: Sreehari Hegden <sreehari.hegden@gmail.com>
Co-authored-by: Fiona la <fionala7@gmail.com>
    @kevingurney @sreeharihegden @lafiona
    3 people committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    8cf062f View commit details
    Browse the repository at this point in the history

  4. Fix Windows build error for the libmexclass integration. 

    Also, update the register proxy macro used to reflect the libmexclass changes for mathworks/libmexclass#20.
Co-authored-by: Fiona la <fionala7@gmail.com>
    @sreeharihegden
    sreeharihegden committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    00568c0 View commit details
    Browse the repository at this point in the history

  5. Use dynamic values in DoubleArray.m, currently making a copy of all v… 

    …alues.
    @lafiona @sreeharihegden
    lafiona authored and sreeharihegden committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    e5c40f2 View commit details
    Browse the repository at this point in the history

  6. Add UInt64 array type, currently attempting no copy, but there is a bug.

    @lafiona @sreeharihegden
    lafiona authored and sreeharihegden committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    32c2819 View commit details
    Browse the repository at this point in the history

  7. Edit arrays to perform no-copy

    @lafiona @sreeharihegden
    lafiona authored and sreeharihegden committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    826b386 View commit details
    Browse the repository at this point in the history

  8. Remove printing in C++ layer

    @lafiona @sreeharihegden
    lafiona authored and sreeharihegden committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    44dd06c View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Install libmexclass binaries in +libmexclass packaged folder to arrow… 

    …_matlab.

Also, updates to reflect latest libmexclass.
    @sreeharihegden
    sreeharihegden committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    77cb963 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Specify CUSTOM_PROXY_FACTORY_HEADER_FILENAME and CUSTOM_PROXY_FACTORY… 

    …_CLASS_NAME.
    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    61ae888 View commit details
    Browse the repository at this point in the history

  2. Remove Proxy subclasses.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    80805b9 View commit details
    Browse the repository at this point in the history

  3. Add basic custom display to arrow.array.DoubleArray which calls Print… 

    … method.
    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    1e4db94 View commit details
    Browse the repository at this point in the history

  4. Remove unused CustomDisplay subclass.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    e000ee1 View commit details
    Browse the repository at this point in the history

  5. Remove UInt64Array and UInt8Array.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    6ed4274 View commit details
    Browse the repository at this point in the history

  6. Remove uint64 and uint8 C++ Proxy source code.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    25fec16 View commit details
    Browse the repository at this point in the history

  7. Remove comment about 'No copy version'.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    d9afe91 View commit details
    Browse the repository at this point in the history

  8. Rearrange header order.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    cd7b7dc View commit details
    Browse the repository at this point in the history

  9. Rename CustomProxyFactory to ArrowProxyFactory.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    718ee4b View commit details
    Browse the repository at this point in the history

  10. Change namespace from proxy::array to arrow::matlab::proxy::array.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    64b2d04 View commit details
    Browse the repository at this point in the history

  11. Remove calls to REGISTER_PROXY for UInt64Array and UInt8Array.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    84acd9d View commit details
    Browse the repository at this point in the history

  12. Update #include for arrow_proxy_factory.h.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    03b8132 View commit details
    Browse the repository at this point in the history

  13. Remove references to UInt64 and UInt8 source files in CMakeLists.txt.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    cc3abaa View commit details
    Browse the repository at this point in the history

  14. Use scope resolution operator to resolve MDA symbol look-up issues.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    433cf35 View commit details
    Browse the repository at this point in the history

  15. Fix STRING typo in CMakeLists.txt.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    5f3e5b4 View commit details
    Browse the repository at this point in the history

  16. Change registered Proxy name from arrow.proxy.array.DoubleArrayProxy … 

    …to arrow.array.proxy.DoubleArray.
    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    ac591ad View commit details
    Browse the repository at this point in the history

  17. Move double_array_proxy source code to array/proxy folder structure.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    e294427 View commit details
    Browse the repository at this point in the history

  18. Rename DoubleArrayProxy to DoubleArray.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    6dfba28 View commit details
    Browse the repository at this point in the history

  19. Update CMakeLists.txt.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    8b86eaa View commit details
    Browse the repository at this point in the history

  20. Update MATLAB Proxy constructor call for arrow.array.DoubleArray to u… 

    …se arrow.array.proxy.DoubleArray.
    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    64f054f View commit details
    Browse the repository at this point in the history

  21. Rename ArrowProxyFactory to Factory.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    b69b598 View commit details
    Browse the repository at this point in the history

  22. Update value of CUSTOM_PROXY_SOURCES to reflect new directory structure.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    cff7364 View commit details
    Browse the repository at this point in the history

  23. Fix CMAKE_SOURCE_DIR typo.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    c89d0fb View commit details
    Browse the repository at this point in the history

  24. Add using namespace declaration for libmexclass::proxy to arrow::matl… 

    …ab::proxy namespace.
    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    f704e19 View commit details
    Browse the repository at this point in the history

  25. Disable warning output from find_package(Arrow) call by adding the QU… 

    …IET flag.
    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    2ff931c View commit details
    Browse the repository at this point in the history

  26. Add tools/cmake to CMAKE_MODULE_PATH.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    0d800a2 View commit details
    Browse the repository at this point in the history

  27. Create tools/cmake directory. Add MATLAB_ARROW_INTERFACE flag.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    dbc5881 View commit details
    Browse the repository at this point in the history

  28. Move libmexclass code into tools/cmake directory.

    @kevingurney
    kevingurney committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    8e7a3e7 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. Fixed build error for MATLAB_ARROW_INTERFACE with include.

    @sreeharihegden
    sreeharihegden committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    884d2b1 View commit details
    Browse the repository at this point in the history

  2. Inherit from matlab.mixin.CustomDisplay.

    @kevingurney
    kevingurney committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    0ea2eb3 View commit details
    Browse the repository at this point in the history

  3. Remove comments referring to libmexclass in CMakeLists.txt.

    @kevingurney
    kevingurney committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    cb85f7b View commit details
    Browse the repository at this point in the history

  4. Remove debug messages.

    @kevingurney
    kevingurney committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    d845a92 View commit details
    Browse the repository at this point in the history

  5. Modify comments. Add success message for libmexclass build.

    @kevingurney
    kevingurney committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    383afdc View commit details
    Browse the repository at this point in the history

  6. Add MATLAB_ARROW_INTERFACE=ON to matlab_build.sh CI script.

    @kevingurney
    kevingurney committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    6b1bad9 View commit details
    Browse the repository at this point in the history

  7. Add arrow_ep as a dependency of libmexclass target.

    @kevingurney
    kevingurney committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    807f743 View commit details
    Browse the repository at this point in the history

  8. Add basic MATLAB test for arrow.array.DoubleArray.

    @kevingurney
    kevingurney committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    95dbd12 View commit details
    Browse the repository at this point in the history

  9. Add missing license headers.

    @kevingurney
    kevingurney committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    239ceaa View commit details
    Browse the repository at this point in the history

  10. Fix linting isssues in CMakeLists.txt.

    @kevingurney
    kevingurney committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    4bf1153 View commit details
    Browse the repository at this point in the history

  11. Rename arrow.array.DoubleArray to arrow.array.Float64Array.

    @kevingurney
    kevingurney committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    5451d76 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Use refactored libmexclass functionality via FetchContent. 

    Co-authored-by: Sreehari Hegden <sreehari.hegden@gmail.com>
    @kevingurney @sreeharihegden
    kevingurney and sreeharihegden committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    6f00627 View commit details
    Browse the repository at this point in the history

  2. Use list(PREPEND ...) to modify CMAKE_MODULE_PATH. 

    Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
    @kevingurney @kou
    kevingurney and kou authored Apr 18, 2023
    Configuration menu
    Copy the full SHA
    0a22524 View commit details
    Browse the repository at this point in the history

  3. Set Arrow_ROOT instead of modifying CMAKE_PREFIX_PATH to configure fi… 

    …nd_package search behavior for Arrow C++ libraries.
    @kevingurney
    kevingurney committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    2ddf128 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Refactor logic for building Arrow from source in order to build Googl… 

    …eTest.
    @kevingurney
    kevingurney committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    38f967a View commit details
    Browse the repository at this point in the history

  2. Error when building in Debug mode on Windows by default.

    @kevingurney
    kevingurney committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    2e59596 View commit details
    Browse the repository at this point in the history

  3. Revert changes related to erroring for Debug builds.

    @kevingurney
    kevingurney committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    37470dd View commit details
    Browse the repository at this point in the history

  4. Fix linting issues with matlab/CMakeLists.txt.

    @kevingurney
    kevingurney committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    66f3548 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Add newlines for readability in ci/scripts/matlab_build.sh. 

    Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
    @kevingurney @kou
    kevingurney and kou authored Apr 21, 2023
    Configuration menu
    Copy the full SHA
    737950a View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Remove $ARROW_INCLUDE_DIRS from $MATLAB_ARROW_LIBMEXCLASS_CLIENT_PROX… 

    …Y_LIBRARY_INCLUDE_DIRS.

Co-authored-by: Sreehari Hegden <sreehari.hegden@gmail.com>
    @kevingurney @sreeharihegden
    kevingurney and sreeharihegden committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    28721d7 View commit details
    Browse the repository at this point in the history