Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-34428: [Python][Docs] Add docsstring for make_fragment #34429

Merged
merged 4 commits into from
Mar 7, 2023

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Mar 3, 2023

@Fokko Fokko requested a review from AlenkaF as a code owner March 3, 2023 12:20
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

⚠️ GitHub issue #34428 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the continuing cleanup.

python/pyarrow/_dataset_parquet.pyx Outdated Show resolved Hide resolved
python/pyarrow/_dataset_parquet.pyx Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Mar 4, 2023
Co-authored-by: Weston Pace <weston.pace@gmail.com>
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Mar 6, 2023
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't realize there were two versions. Same clarification on partition_expression. Once that is in I think this is good to go.

python/pyarrow/_dataset.pyx Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Mar 6, 2023
Co-authored-by: Weston Pace <weston.pace@gmail.com>
@Fokko
Copy link
Contributor Author

Fokko commented Mar 7, 2023

@westonpace Good to go!

@westonpace westonpace merged commit f7fbfca into apache:main Mar 7, 2023
@ursabot
Copy link

ursabot commented Mar 7, 2023

Benchmark runs are scheduled for baseline = 2e4a96c and contender = f7fbfca. f7fbfca is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.46% ⬆️0.0%] test-mac-arm
[Finished ⬇️1.02% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.83% ⬆️0.1%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] f7fbfcaf ec2-t3-xlarge-us-east-2
[Failed] f7fbfcaf test-mac-arm
[Finished] f7fbfcaf ursa-i9-9960x
[Finished] f7fbfcaf ursa-thinkcentre-m75q
[Finished] 2e4a96c6 ec2-t3-xlarge-us-east-2
[Failed] 2e4a96c6 test-mac-arm
[Finished] 2e4a96c6 ursa-i9-9960x
[Finished] 2e4a96c6 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Mar 14, 2023

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python] Add missing docs on make_fragement
3 participants