-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-1712: [C++] Add method to BinaryBuilder to reserve space for value data #1481
Commits on Jan 15, 2018
-
Configuration menu - View commit details
-
Copy full SHA for c2f8dc4 - Browse repository at this point
Copy the full SHA c2f8dc4View commit details -
Update BinaryBuilder::Resize(int64_t capacity) in builder.cc
When building BinaryArrays with a known size using Resize and Reserve methods, space is also reserved for value_data_builder_ to prevent internal reallocation
Configuration menu - View commit details
-
Copy full SHA for 232024e - Browse repository at this point
Copy the full SHA 232024eView commit details -
Merge pull request #2 from xuepanchen/xuepanchen-arrow-1712
Update BinaryBuilder::Resize(int64_t capacity) in builder.cc
Configuration menu - View commit details
-
Copy full SHA for d021c54 - Browse repository at this point
Copy the full SHA d021c54View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b73c1c - Browse repository at this point
Copy the full SHA 5b73c1cView commit details
Commits on Jan 16, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 5ebfb32 - Browse repository at this point
Copy the full SHA 5ebfb32View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0434e6 - Browse repository at this point
Copy the full SHA e0434e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for de318f4 - Browse repository at this point
Copy the full SHA de318f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b002e0b - Browse repository at this point
Copy the full SHA b002e0bView commit details
Commits on Jan 17, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 8dd5eaa - Browse repository at this point
Copy the full SHA 8dd5eaaView commit details -
Update ReserveData(int64_t) method signature for BinaryBuilder
Replace parameter name from "bytes" to "capacity" to avoid confusion.
Configuration menu - View commit details
-
Copy full SHA for 9b5e805 - Browse repository at this point
Copy the full SHA 9b5e805View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a5593e - Browse repository at this point
Copy the full SHA 5a5593eView commit details
Commits on Jan 18, 2018
-
Add test case for array-test.cc
Add TestCapacityReserve to test space reservation for BinaryBuilder
Configuration menu - View commit details
-
Copy full SHA for 15e045c - Browse repository at this point
Copy the full SHA 15e045cView commit details -
Configuration menu - View commit details
-
Copy full SHA for bbc6527 - Browse repository at this point
Copy the full SHA bbc6527View commit details -
ARROW-1945: [C++] Add data_capacity_ to track capacity of value data
data_capacity_ represents the indicated capacity for value_data_builder and it is always smaller than or equal to the actual capacity of underlying value_data_builder (data_capacity_ <= value_data_builder.capacity()). That's because when we say: ReserveData(capacity); The new capacity is max(data_capacity_, data length + capacity), and data_capacity_ is set to be equal to new capacity but underlying buffer size is set to BitUtil::RoundUpToMultipleOf64(new capacity) to ensure that the capacity of the buffer is a multiple of 64 bytes as defined in Layout.md. That's why data_capacity_ is needed to show the indicated capacity of the BinaryBuilder, just like ArrayBuilder::capacity_ indicates the indicated capacity of ArrayBuilder. A safety check is added in BinaryBuilder::Append() to update data_capacity_ if data length is greater than data_capacity_. The reason is that data_capacity is updated in ResearveData(). But if users make mistakes to append too much data, data length might be larger than data_capacity_ (data length <= actual capacity of underlying value_data_builder). If this happens data_capacity_ is set equal to data length to avoid confusion.
Configuration menu - View commit details
-
Copy full SHA for 18f90fb - Browse repository at this point
Copy the full SHA 18f90fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b07895 - Browse repository at this point
Copy the full SHA 0b07895View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3c8202 - Browse repository at this point
Copy the full SHA d3c8202View commit details
Commits on Jan 19, 2018
-
Merge pull request #3 from xuepanchen/xuepanchen-arrow-1712
Update ReserveData(int64_t) method for BinaryBuilder
Configuration menu - View commit details
-
Copy full SHA for 8e4c892 - Browse repository at this point
Copy the full SHA 8e4c892View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a5b70e - Browse repository at this point
Copy the full SHA 5a5b70eView commit details
Commits on Jan 20, 2018
-
Configuration menu - View commit details
-
Copy full SHA for bc5db7d - Browse repository at this point
Copy the full SHA bc5db7dView commit details
Commits on Jan 22, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 77f8f3c - Browse repository at this point
Copy the full SHA 77f8f3cView commit details -
ARROW-1712: [C++] Modify test case for BinaryBuilder::ReserveData() a…
…nd change arguments for offsets_builder_.Resize()
Configuration menu - View commit details
-
Copy full SHA for d4bbd15 - Browse repository at this point
Copy the full SHA d4bbd15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 360e601 - Browse repository at this point
Copy the full SHA 360e601View commit details
Commits on Jan 23, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 707b67b - Browse repository at this point
Copy the full SHA 707b67bView commit details