ARROW-18383: [C++] Avoid global variables for thread pools and at-fork handlers #14704
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format? or See also: |
|
@github-actions crossbow submit -g cpp |
|
@paleolimbot This seems to fix the R issues with |
This comment was marked as outdated.
This comment was marked as outdated.
|
I checked my little to R process forking reprex from #14250 ( |
…k handlers Initialization order of module globals is undefined. In a particular case, the IO thread pool would first be instantiated at library load, registering an at-fork handler. Then, only after, the at-fork handlers would be initialized, losing the handler registered just before.
pitrou
force-pushed
the
cpp-state-lazy
branch
from
89398df
to
be52dbc
Compare
pitrou
changed the title
|
|
|
@github-actions crossbow submit -g cpp |
|
Revision: be52dbc Submitted crossbow builds: ursacomputing/crossbow @ actions-c54517457f
|
|
Benchmark runs are scheduled for baseline = 1121bbc and contender = b1f65ea. b1f65ea is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Initialization order of module globals is undefined.
In a particular case, the IO thread pool would first be instantiated at library load, registering an at-fork handler.
Then, only after, the at-fork handlers would be initialized, losing the handler registered just before.