Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-18256: [C++][Windows] Use IMPORTED_IMPLIB for external shared Thrift #14595

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

kou
Copy link
Member

@kou kou commented Nov 6, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@kou
Copy link
Member Author

kou commented Nov 7, 2022

@evetion Does this work with your use case?

@kou kou force-pushed the cpp-cmake-thrift-windows branch from aad9065 to 33a0cc8 Compare November 16, 2022 07:07
@kou
Copy link
Member Author

kou commented Nov 17, 2022

@github-actions crossbow submit -g cpp

@github-actions
Copy link

Revision: 33a0cc8

Submitted crossbow builds: ursacomputing/crossbow @ actions-e5c6d1c175

Task Status
test-alpine-linux-cpp Github Actions
test-build-cpp-fuzz Github Actions
test-conda-cpp Github Actions
test-conda-cpp-valgrind Azure
test-cuda-cpp Github Actions
test-debian-10-cpp-amd64 Github Actions
test-debian-10-cpp-i386 Github Actions
test-debian-11-cpp-amd64 Github Actions
test-debian-11-cpp-i386 Github Actions
test-fedora-35-cpp Github Actions
test-ubuntu-18.04-cpp Github Actions
test-ubuntu-18.04-cpp-release Github Actions
test-ubuntu-18.04-cpp-static Github Actions
test-ubuntu-20.04-cpp Github Actions
test-ubuntu-20.04-cpp-20 Github Actions
test-ubuntu-20.04-cpp-bundled Github Actions
test-ubuntu-20.04-cpp-thread-sanitizer Github Actions
test-ubuntu-22.04-cpp Github Actions

@kou
Copy link
Member Author

kou commented Nov 18, 2022

+1

@kou kou merged commit 501b799 into apache:master Nov 18, 2022
@kou kou deleted the cpp-cmake-thrift-windows branch November 18, 2022 04:34
@ursabot
Copy link

ursabot commented Nov 18, 2022

Benchmark runs are scheduled for baseline = c7a4ee7 and contender = 501b799. 501b799 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.81% ⬆️0.2%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.66% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 501b7997 ec2-t3-xlarge-us-east-2
[Finished] 501b7997 test-mac-arm
[Failed] 501b7997 ursa-i9-9960x
[Finished] 501b7997 ursa-thinkcentre-m75q
[Finished] c7a4ee78 ec2-t3-xlarge-us-east-2
[Finished] c7a4ee78 test-mac-arm
[Failed] c7a4ee78 ursa-i9-9960x
[Finished] c7a4ee78 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants