-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17975: [C++] Create at-fork facility #14594
Conversation
@github-actions crossbow submit -g cpp |
Revision: 961a457 Submitted crossbow builds: ursacomputing/crossbow @ actions-21ee6e6b86 |
Thanks for doing this. Looks like a very useful utility and IIRC the atfork handlers should be a safer way of solving this problem too. |
Yes, hopefully it should be more robust than the previous way of inspecting the current pid in random places... |
Benchmark runs are scheduled for baseline = 7f067f9 and contender = 619b034. 619b034 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Also migrate the `ThreadPool` class to use the new facility. The `util::GlobalForkSafeMutex` facility is now unused, we may want to remove it in a later PR. Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Also migrate the `ThreadPool` class to use the new facility. The `util::GlobalForkSafeMutex` facility is now unused, we may want to remove it in a later PR. Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Also migrate the
ThreadPool
class to use the new facility.The
util::GlobalForkSafeMutex
facility is now unused, we may want to remove it in a later PR.