Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17840: [Java] Disable flaky JaCoCo coverage check #14231

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

lidavidm
Copy link
Member

The check doesn't add much value, and makes things flaky because whether a branch is covered or not can come down to chance based on where exactly an exception occurs.

@github-actions
Copy link

@lidavidm
Copy link
Member Author

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: 63a87f5

Submitted crossbow builds: ursacomputing/crossbow @ actions-b04d06f201

Task Status
java-jars Github Actions

The check doesn't add much value, and makes things flaky because
whether a branch is covered or not can come down to chance based
on where exactly an exception occurs.
@lidavidm
Copy link
Member Author

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: 9823720

Submitted crossbow builds: ursacomputing/crossbow @ actions-c3889846c2

Task Status
java-jars Github Actions

@lidavidm lidavidm marked this pull request as ready for review September 26, 2022 11:28
@lwhite1
Copy link
Contributor

lwhite1 commented Sep 26, 2022

What's the connection between JaCoCo and the JDK8 and JDK9+ profiles?

@lidavidm
Copy link
Member Author

We used to have to pass more options to Surefire to get JaCoCo to work, so we had to duplicate some of the test config (since JDK8/9+ require different Surefire options). Now that we're not using JaCoCo, we also don't need that config, so we can simplify it

@lwhite1
Copy link
Contributor

lwhite1 commented Sep 26, 2022

We used to have to pass more options to Surefire to get JaCoCo to work, so we had to duplicate some of the test config (since JDK8/9+ require different Surefire options). Now that we're not using JaCoCo, we also don't need that config, so we can simplify it

Makes sense.

Copy link
Contributor

@lwhite1 lwhite1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@lidavidm lidavidm merged commit 9b4a181 into apache:master Sep 26, 2022
@lidavidm lidavidm deleted the arrow-17840 branch September 26, 2022 17:02
@ursabot
Copy link

ursabot commented Sep 26, 2022

Benchmark runs are scheduled for baseline = acd69f9 and contender = 9b4a181. 9b4a181 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.34% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.55% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.07% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 9b4a181d ec2-t3-xlarge-us-east-2
[Failed] 9b4a181d test-mac-arm
[Failed] 9b4a181d ursa-i9-9960x
[Finished] 9b4a181d ursa-thinkcentre-m75q
[Finished] acd69f92 ec2-t3-xlarge-us-east-2
[Failed] acd69f92 test-mac-arm
[Failed] acd69f92 ursa-i9-9960x
[Finished] acd69f92 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Sep 26, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
The check doesn't add much value, and makes things flaky because whether a branch is covered or not can come down to chance based on where exactly an exception occurs.

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants