ARROW-12702: [JS] Update webpack and terser #10275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domoritz
changed the title
domoritz
commented
May 8, 2021
| output: { comments: false, beautify: false }, | ||
| compress: { unsafe: true }, | ||
| mangle: true, | ||
| safari10: true // <-- works around safari10 bugs, see the "safari10" option here: https://github.com/terser-js/terser#minify-options |
There was a problem hiding this comment.
Safari 10 is sufficiently old enough that we don't need this anymore.
domoritz
commented
May 8, 2021
| @@ -83,7 +81,7 @@ const minifyTask = ((cache, commonConfig) => memoizeTask(cache, function minifyJ | |||
| }))({}, { | |||
| resolve: { mainFields: [`module`, `main`] }, | |||
| module: { rules: [{ test: /\.js$/, enforce: `pre`, use: [`source-map-loader`] }] }, | |||
| output: { filename: '[name].js', library: mainExport, libraryTarget: `umd`, umdNamedDefine: true }, | |||
| output: { filename: '[name].js', library: mainExport, libraryTarget: `umd`, umdNamedDefine: true, globalObject: 'this' }, | |||
There was a problem hiding this comment.
No idea why this is needed.
trxcllnt
approved these changes
May 15, 2021
|
@domoritz Could you rebase on master to merge this? |
|
I merged master so this should be good to squash and merge. |
|
Thanks. I'll merge this. |
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
Closes apache#10275 from domoritz/webpack Authored-by: Dominik Moritz <domoritz@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.